Fix rematch process

[vchess.git] / server / routes / games.js

diff --git a/server/routes/games.js b/server/routes/games.js
index 73a8bf7..a86a76d 100644 (file)
--- a/server/routes/games.js
+++ b/server/routes/games.js
@@ -1,68 +1,106 @@
-var router = require("express").Router();
-var UserModel = require("../models/User");
-var ChallengeModel = require('../models/Challenge');
-var GameModel = require('../models/Game');
-var VariantModel = require('../models/Variant');
-var access = require("../utils/access");
-var params = require("../config/parameters");
+let router = require("express").Router();
+const UserModel = require("../models/User");
+const ChallengeModel = require('../models/Challenge');
+const GameModel = require('../models/Game');
+const access = require("../utils/access");
+const params = require("../config/parameters");
 
 // From main hall, start game between players 0 and 1
 router.post("/games", access.logged, access.ajax, (req,res) => {
   const gameInfo = req.body.gameInfo;
-       if (!gameInfo.players.some(p => p.id == req.userId))
-               return res.json({errmsg: "Cannot start someone else's game"});
+  // Challenge ID is provided if game start from Hall:
   const cid = req.body.cid;
-  ChallengeModel.remove(cid);
-       const fen = req.body.fen;
-       GameModel.create(
-    gameInfo.vid, gameInfo.fen, gameInfo.timeControl, gameInfo.players,
-               (err,ret) => {
-                       access.checkRequest(res, err, ret, "Cannot create game", () => {
+  if (
+    Array.isArray(gameInfo.players) &&
+    gameInfo.players.some(p => p.uid == req.userId) &&
+    (!cid || cid.toString().match(/^[0-9]+$/)) &&
+    GameModel.checkGameInfo(gameInfo)
+  ) {
+    if (!!cid) ChallengeModel.remove(cid);
+    GameModel.create(
+      gameInfo.vid, gameInfo.fen, gameInfo.cadence, gameInfo.players,
+      (err,ret) => {
         const oppIdx = (gameInfo.players[0].id == req.userId ? 1 : 0);
         const oppId = gameInfo.players[oppIdx].id;
         UserModel.tryNotify(oppId,
-          "New game: " + params.siteURL + "/game/" + ret.gid);
-                               res.json({gameId: ret.gid});
-                       });
-               }
-       );
+          "Game started: " + params.siteURL + "/#/game/" + ret.gid);
+        res.json({gameId: ret.gid});
+      }
+    );
+  }
 });
 
 router.get("/games", access.ajax, (req,res) => {
-       const gameId = req.query["gid"];
-       if (!!gameId)
+  const gameId = req.query["gid"];
+  if (gameId)
   {
-    GameModel.getOne(gameId, (err,game) => {
-                 access.checkRequest(res, err, game, "Game not found", () => {
-                         res.json({game: game});
-                 });
-         });
+    if (gameId.match(/^[0-9]+$/))
+    {
+      GameModel.getOne(gameId, (err,game) => {
+        res.json({game: game});
+      });
+    }
   }
   else
   {
     // Get by (non-)user ID:
     const userId = req.query["uid"];
-    const excluded = !!req.query["excluded"];
-    GameModel.getByUser(userId, excluded, (err,games) => {
-                 if (!!err)
-        return res.json({errmsg: err.errmsg || err.toString()});
-                       res.json({games: games});
-         });
+    if (userId.match(/^[0-9]+$/))
+    {
+      const excluded = !!req.query["excluded"];
+      GameModel.getByUser(userId, excluded, (err,games) => {
+        res.json({games: games});
+      });
+    }
   }
 });
 
-// New move + fen update + score, potentially
-// TODO: if newmove fail, takeback in GUI
+// FEN update + score(Msg) + draw status / and new move + chats
 router.put("/games", access.logged, access.ajax, (req,res) => {
-       const gid = req.body.gid;
-       const obj = req.body.newObj;
-       GameModel.update(gid, obj, (err) => {
-               if (!!err)
-      return res.json(err);
-    if (!!req.body.offlineOpp) //TODO: refresh this...
-      UserModel.tryNotify(req.body.offlineOpp, "New move in game " + gid);
-    res.json({});
-       });
+  const gid = req.body.gid;
+  let obj = req.body.newObj;
+  if (gid.toString().match(/^[0-9]+$/) && GameModel.checkGameUpdate(obj))
+  {
+    GameModel.getPlayers(gid, (err,players) => {
+      const myIdx = players.findIndex(p => p.uid == req.userId)
+      if (myIdx >= 0) {
+        // Did I mark the game for deletion?
+        if (!!obj.removeFlag) {
+          obj.deletedBy = ["w","b"][myIdx];
+          delete obj["removeFlag"];
+        }
+        GameModel.update(gid, obj, (err) => {
+          if (!err && (!!obj.move || !!obj.score))
+          {
+            // Notify opponent if he enabled notifications:
+            const oppid = players[0].uid == req.userId
+              ? players[1].uid
+              : players[0].uid;
+            const messagePrefix = obj.move
+              ? "New move in game: "
+              : "Game ended: ";
+            UserModel.tryNotify(oppid,
+              messagePrefix + params.siteURL + "/#/game/" + gid);
+          }
+          res.json(err || {});
+        });
+      }
+    });
+  }
+});
+
+// TODO: chats deletion here, but could/should be elsewhere.
+// Moves update also could, although logical unit in a game.
+router.delete("/chats", access.logged, access.ajax, (req,res) => {
+  const gid = req.query["gid"];
+  GameModel.getPlayers(gid, (err,players) => {
+    if (players.some(p => p.uid == req.userId))
+    {
+      GameModel.update(gid, {delchat: true}, () => {
+        res.json({});
+      });
+    }
+  });
 });
 
 module.exports = router;