rename getOppCol into static GetOppCol + start thinking about problems page
[vchess.git] / public / javascripts / base_rules.js
index 50766b0..718261d 100644 (file)
@@ -66,10 +66,13 @@ class ChessRules
                // 2) Check turn
                if (!fenParsed.turn || !V.IsGoodTurn(fenParsed.turn))
                        return false;
-               // 3) Check flags
+               // 3) Check moves count
+               if (!fenParsed.movesCount || !(parseInt(fenParsed.movesCount) >= 0))
+                       return false;
+               // 4) Check flags
                if (V.HasFlags && (!fenParsed.flags || !V.IsGoodFlags(fenParsed.flags)))
                        return false;
-               // 4) Check enpassant
+               // 5) Check enpassant
                if (V.HasEnpassant &&
                        (!fenParsed.enpassant || !V.IsGoodEnpassant(fenParsed.enpassant)))
                {
@@ -186,7 +189,8 @@ class ChessRules
                // Argument is a move:
                const move = moveOrSquare;
                const [sx,sy,ex] = [move.start.x,move.start.y,move.end.x];
-               if (move.appear[0].p == V.PAWN && Math.abs(sx - ex) == 2)
+               // TODO: next conditions are first for Atomic, and third for Checkered
+               if (move.appear.length > 0 && move.appear[0].p == V.PAWN && ["w","b"].includes(move.appear[0].c) && Math.abs(sx - ex) == 2)
                {
                        return {
                                x: (sx + ex)/2,
@@ -287,8 +291,9 @@ class ChessRules
                {
                        position: fenParts[0],
                        turn: fenParts[1],
+                       movesCount: fenParts[2],
                };
-               let nextIdx = 2;
+               let nextIdx = 3;
                if (V.HasFlags)
                        Object.assign(res, {flags: fenParts[nextIdx++]});
                if (V.HasEnpassant)
@@ -299,7 +304,8 @@ class ChessRules
        // Return current fen (game state)
        getFen()
        {
-               return this.getBaseFen() + " " + this.getTurnFen() +
+               return this.getBaseFen() + " " +
+                       this.getTurnFen() + " " + this.movesCount +
                        (V.HasFlags ? (" " + this.getFlagsFen()) : "") +
                        (V.HasEnpassant ? (" " + this.getEnpassantFen()) : "");
        }
@@ -400,12 +406,12 @@ class ChessRules
        // INITIALIZATION
 
        // Fen string fully describes the game state
-       constructor(fen, moves)
+       constructor(fen)
        {
-               this.moves = moves;
                const fenParsed = V.ParseFen(fen);
                this.board = V.GetBoard(fenParsed.position);
                this.turn = fenParsed.turn[0]; //[0] to work with MarseilleRules
+               this.movesCount = parseInt(fenParsed.movesCount);
                this.setOtherVariables(fen);
        }
 
@@ -492,15 +498,15 @@ class ChessRules
        }
 
        // Get opponent color
-       getOppCol(color)
+       static GetOppCol(color)
        {
                return (color=="w" ? "b" : "w");
        }
 
-       get lastMove()
+       // Get next color (for compatibility with 3 and 4 players games)
+       static GetNextCol(color)
        {
-               const L = this.moves.length;
-               return (L>0 ? this.moves[L-1] : null);
+               return V.GetOppCol(color);
        }
 
        // Pieces codes (for a clearer code)
@@ -1036,14 +1042,12 @@ class ChessRules
                        this.kingPos[c] = [move.start.x, move.start.y];
        }
 
-       play(move, ingame)
+       play(move)
        {
                // DEBUG:
 //             if (!this.states) this.states = [];
-//             if (!ingame) this.states.push(this.getFen());
-
-               if (!!ingame)
-                       move.notation = [this.getNotation(move), this.getLongNotation(move)];
+//             const stateFen = this.getBaseFen() + this.getTurnFen() + this.getFlagsFen();
+//             this.states.push(stateFen);
 
                if (V.HasFlags)
                        move.flags = JSON.stringify(this.aggregateFlags()); //save flags (for undo)
@@ -1051,14 +1055,8 @@ class ChessRules
                        this.epSquares.push( this.getEpSquare(move) );
                V.PlayOnBoard(this.board, move);
                this.turn = this.getOppCol(this.turn);
-               this.moves.push(move);
+               this.movesCount++;
                this.updateVariables(move);
-
-               if (!!ingame)
-               {
-                       // Hash of current game state *after move*, to detect repetitions
-                       move.hash = hex_md5(this.getFen());
-               }
        }
 
        undo(move)
@@ -1069,54 +1067,25 @@ class ChessRules
                        this.disaggregateFlags(JSON.parse(move.flags));
                V.UndoOnBoard(this.board, move);
                this.turn = this.getOppCol(this.turn);
-               this.moves.pop();
+               this.movesCount--;
                this.unupdateVariables(move);
 
                // DEBUG:
-//             if (this.getFen() != this.states[this.states.length-1])
-//                     debugger;
+//             const stateFen = this.getBaseFen() + this.getTurnFen() + this.getFlagsFen();
+//             if (stateFen != this.states[this.states.length-1]) debugger;
 //             this.states.pop();
        }
 
        ///////////////
        // END OF GAME
 
-       // Check for 3 repetitions (position + flags + turn)
-       checkRepetition()
+       // What is the score ? (Interesting if game is over)
+       getCurrentScore()
        {
-               if (!this.hashStates)
-                       this.hashStates = {};
-               const startIndex =
-                       Object.values(this.hashStates).reduce((a,b) => { return a+b; }, 0)
-               // Update this.hashStates with last move (or all moves if continuation)
-               // NOTE: redundant storage, but faster and moderate size
-               for (let i=startIndex; i<this.moves.length; i++)
-               {
-                       const move = this.moves[i];
-                       if (!this.hashStates[move.hash])
-                               this.hashStates[move.hash] = 1;
-                       else
-                               this.hashStates[move.hash]++;
-               }
-               return Object.values(this.hashStates).some(elt => { return (elt >= 3); });
-       }
-
-       // Is game over ? And if yes, what is the score ?
-       checkGameOver()
-       {
-               if (this.checkRepetition())
-                       return "1/2";
-
                if (this.atLeastOneMove()) // game not over
                        return "*";
 
                // Game over
-               return this.checkGameEnd();
-       }
-
-       // No moves are possible: compute score
-       checkGameEnd()
-       {
                const color = this.turn;
                // No valid move: stalemate or checkmate?
                if (!this.isAttacked(this.kingPos[color], [this.getOppCol(color)]))
@@ -1165,11 +1134,10 @@ class ChessRules
                {
                        this.play(moves1[i]);
                        let finish = (Math.abs(this.evalPosition()) >= V.THRESHOLD_MATE);
-                       if (!finish && !this.atLeastOneMove())
+                       if (!finish)
                        {
-                               // Test mate (for other variants)
-                               const score = this.checkGameEnd();
-                               if (score != "1/2")
+                               const score = this.getCurrentScore();
+                               if (["1-0","0-1"].includes(score))
                                        finish = true;
                        }
                        this.undo(moves1[i]);
@@ -1183,8 +1151,9 @@ class ChessRules
                        // Initial self evaluation is very low: "I'm checkmated"
                        moves1[i].eval = (color=="w" ? -1 : 1) * maxeval;
                        this.play(moves1[i]);
+                       const score1 = this.getCurrentScore();
                        let eval2 = undefined;
-                       if (this.atLeastOneMove())
+                       if (score1 == "*")
                        {
                                // Initial enemy evaluation is very low too, for him
                                eval2 = (color=="w" ? 1 : -1) * maxeval;
@@ -1193,15 +1162,10 @@ class ChessRules
                                for (let j=0; j<moves2.length; j++)
                                {
                                        this.play(moves2[j]);
-                                       let evalPos = undefined;
-                                       if (this.atLeastOneMove())
-                                               evalPos = this.evalPosition()
-                                       else
-                                       {
-                                               // Working with scores is more accurate (necessary for Loser variant)
-                                               const score = this.checkGameEnd();
-                                               evalPos = (score=="1/2" ? 0 : (score=="1-0" ? 1 : -1) * maxeval);
-                                       }
+                                       const score2 = this.getCurrentScore();
+                                       const evalPos = score2 == "*"
+                                               ? this.evalPosition()
+                                               : (score2=="1/2" ? 0 : (score2=="1-0" ? 1 : -1) * maxeval);
                                        if ((color == "w" && evalPos < eval2)
                                                || (color=="b" && evalPos > eval2))
                                        {
@@ -1211,10 +1175,7 @@ class ChessRules
                                }
                        }
                        else
-                       {
-                               const score = this.checkGameEnd();
-                               eval2 = (score=="1/2" ? 0 : (score=="1-0" ? 1 : -1) * maxeval);
-                       }
+                               eval2 = (score1=="1/2" ? 0 : (score1=="1-0" ? 1 : -1) * maxeval);
                        if ((color=="w" && eval2 > moves1[i].eval)
                                || (color=="b" && eval2 < moves1[i].eval))
                        {
@@ -1262,17 +1223,9 @@ class ChessRules
   {
                const maxeval = V.INFINITY;
                const color = this.turn;
-               if (!this.atLeastOneMove())
-               {
-                       switch (this.checkGameEnd())
-                       {
-                               case "1/2":
-                                       return 0;
-                               default:
-                                       const score = this.checkGameEnd();
-                                       return (score=="1/2" ? 0 : (score=="1-0" ? 1 : -1) * maxeval);
-                       }
-               }
+               const score = this.getCurrentScore();
+               if (score != "*")
+                       return (score=="1/2" ? 0 : (score=="1-0" ? 1 : -1) * maxeval);
                if (depth == 0)
       return this.evalPosition();
                const moves = this.getAllValidMoves("computer");
@@ -1327,6 +1280,7 @@ class ChessRules
        /////////////////////////
 
        // Context: just before move is played, turn hasn't changed
+       // TODO: un-ambiguous notation (switch on piece type, check directions...)
        getNotation(move)
        {
                if (move.appear.length == 2 && move.appear[0].p == V.KING) //castle
@@ -1369,36 +1323,33 @@ class ChessRules
        }
 
        // The score is already computed when calling this function
-       getPGN(mycolor, score, fenStart, mode)
+       getPGN(moves, mycolor, score, fenStart, mode)
        {
                let pgn = "";
-               pgn += '[Site "vchess.club"]<br>';
+               pgn += '[Site "vchess.club"]\n';
                const opponent = mode=="human" ? "Anonymous" : "Computer";
-               pgn += '[Variant "' + variant + '"]<br>';
-               pgn += '[Date "' + getDate(new Date()) + '"]<br>';
-               pgn += '[White "' + (mycolor=='w'?'Myself':opponent) + '"]<br>';
-               pgn += '[Black "' + (mycolor=='b'?'Myself':opponent) + '"]<br>';
-               pgn += '[FenStart "' + fenStart + '"]<br>';
-               pgn += '[Fen "' + this.getFen() + '"]<br>';
-               pgn += '[Result "' + score + '"]<br><br>';
-
-               // Standard PGN
-               for (let i=0; i<this.moves.length; i++)
-               {
-                       if (i % 2 == 0)
-                               pgn += ((i/2)+1) + ".";
-                       pgn += this.moves[i].notation[0] + " ";
-               }
-               pgn += "<br><br>";
-
-               // "Complete moves" PGN (helping in ambiguous cases)
-               for (let i=0; i<this.moves.length; i++)
+               pgn += '[Variant "' + variant + '"]\n';
+               pgn += '[Date "' + getDate(new Date()) + '"]\n';
+               // TODO: later when users are a bit less anonymous, use better names
+               const whiteName = ["human","computer"].includes(mode)
+                       ? (mycolor=='w'?'Myself':opponent)
+                       : "analyze";
+               const blackName = ["human","computer"].includes(mode)
+                       ? (mycolor=='b'?'Myself':opponent)
+                       : "analyze";
+               pgn += '[White "' + whiteName + '"]\n';
+               pgn += '[Black "' + blackName + '"]\n';
+               pgn += '[Fen "' + fenStart + '"]\n';
+               pgn += '[Result "' + score + '"]\n\n';
+
+               // Print moves
+               for (let i=0; i<moves.length; i++)
                {
                        if (i % 2 == 0)
                                pgn += ((i/2)+1) + ".";
-                       pgn += this.moves[i].notation[1] + " ";
+                       pgn += moves[i].notation + " ";
                }
 
-               return pgn;
+               return pgn + "\n";
        }
 }