Left some TODOs, some bugs
[vchess.git] / client / src / views / Hall.vue
index 2180509..8cd330f 100644 (file)
@@ -1,24 +1,24 @@
 <template lang="pug">
 main
   input#modalInfo.modal(type="checkbox")
-  div(role="dialog" aria-labelledby="infoMessage")
+  div#infoDiv(role="dialog" data-checkbox="modalInfo" aria-labelledby="infoMessage")
     .card.smallpad.small-modal.text-center
       label.modal-close(for="modalInfo")
       h3#infoMessage.section
         p(v-html="infoMessage")
   input#modalNewgame.modal(type="checkbox")
-  div(role="dialog" data-checkbox="modalNewgame"
+  div#newgameDiv(role="dialog" data-checkbox="modalNewgame"
       aria-labelledby="titleFenedit")
     .card.smallpad(@keyup.enter="newChallenge")
       label#closeNewgame.modal-close(for="modalNewgame")
       fieldset
-        label(for="selectVariant") {{ st.tr["Variant"] }}
+        label(for="selectVariant") {{ st.tr["Variant"] }} *
         select#selectVariant(v-model="newchallenge.vid")
           option(v-for="v in st.variants" :value="v.id"
               :selected="newchallenge.vid==v.id")
             | {{ v.name }}
       fieldset
-        label(for="timeControl") {{ st.tr["Time control"] }}
+        label(for="timeControl") {{ st.tr["Time control"] }} *
         div#predefinedTimeControls
           button 3+2
           button 5+3
@@ -26,29 +26,29 @@ main
         input#timeControl(type="text" v-model="newchallenge.timeControl"
           placeholder="5+0, 1h+30s, 7d+1d ...")
       fieldset(v-if="st.user.id > 0")
-        label(for="selectPlayers") {{ st.tr["Play with? (optional)"] }}
+        label(for="selectPlayers") {{ st.tr["Play with?"] }}
         input#selectPlayers(type="text" v-model="newchallenge.to")
       fieldset(v-if="st.user.id > 0 && newchallenge.to.length > 0")
-        label(for="inputFen") {{ st.tr["FEN (optional)"] }}
+        label(for="inputFen") FEN
         input#inputFen(type="text" v-model="newchallenge.fen")
       button(@click="newChallenge") {{ st.tr["Send challenge"] }}
   .row
     .col-sm-12
-      button#newGame(onClick="doClick('modalNewgame')") New game
+      button#newGame(onClick="doClick('modalNewgame')") {{ st.tr["New game"] }}
   .row
     .col-sm-12.col-md-10.col-md-offset-1.col-lg-8.col-lg-offset-2
       div
         .button-group
           button(@click="(e) => setDisplay('c','live',e)" class="active")
-            | Live Challenges
+            | {{ st.tr["Live challenges"] }}
           button(@click="(e) => setDisplay('c','corr',e)")
-            | Correspondance challenges
+            | {{ st.tr["Correspondance challenges"] }}
         ChallengeList(v-show="cdisplay=='live'"
           :challenges="filterChallenges('live')" @click-challenge="clickChallenge")
         ChallengeList(v-show="cdisplay=='corr'"
           :challenges="filterChallenges('corr')" @click-challenge="clickChallenge")
       #people
-        h3.text-center Who's there?
+        h3.text-center {{ st.tr["Who's there?"] }}
         #players
           p(v-for="p in Object.values(people)" v-if="!!p.name")
             span {{ p.name }}
@@ -59,14 +59,14 @@ main
               | {{ whatPlayerDoes(p) }}
           p.anonymous @nonymous ({{ anonymousCount }})
         #chat
-          Chat(:players="[]")
+          Chat(:newChat="newChat" @mychat="processChat")
         .clearer
       div
         .button-group
           button(@click="(e) => setDisplay('g','live',e)" class="active")
-            | Live games
+            | {{ st.tr["Live games"] }}
           button(@click="(e) => setDisplay('g','corr',e)")
-            | Correspondance games
+            | {{ st.tr["Correspondance games"] }}
         GameList(v-show="gdisplay=='live'" :games="filterGames('live')"
           @show-game="showGame")
         GameList(v-show="gdisplay=='corr'" :games="filterGames('corr')"
@@ -83,6 +83,8 @@ import Chat from "@/components/Chat.vue";
 import GameList from "@/components/GameList.vue";
 import ChallengeList from "@/components/ChallengeList.vue";
 import { GameStorage } from "@/utils/gameStorage";
+import { processModalClick } from "@/utils/modalClick";
+
 export default {
   name: "my-hall",
   components: {
@@ -106,6 +108,7 @@ export default {
         to: "", //name of challenged player (if any)
         timeControl: localStorage.getItem("timeControl") || "",
       },
+      newChat: "",
     };
   },
   watch: {
@@ -194,6 +197,7 @@ export default {
       // after we're sure WebSocket is initialized
       this.st.conn.send(JSON.stringify({code:"connect"}));
       this.st.conn.send(JSON.stringify({code:"pollclients"}));
+      this.st.conn.send(JSON.stringify({code:"pollgamers"}));
     };
     if (!!this.st.conn && this.st.conn.readyState == 1) //1 == OPEN state
       funcPollClients();
@@ -208,6 +212,8 @@ export default {
     this.st.conn.onclose = socketCloseListener;
   },
   mounted: function() {
+    [document.getElementById("infoDiv"),document.getElementById("newgameDiv")]
+      .forEach(elt => elt.addEventListener("click", processModalClick));
     document.querySelectorAll("#predefinedTimeControls > button").forEach(
       (b) => { b.addEventListener("click",
         () => { this.newchallenge.timeControl = b.innerHTML; }
@@ -247,6 +253,10 @@ export default {
       // this.st.variants might be uninitialized (variant == null)
       return (!!variant ? variant.name : "");
     },
+
+// TODO: now that we can distinguish people from Hall or Game,
+// improve this --> the info is already known
+
     whatPlayerDoes: function(p) {
       if (this.games.some(g => g.type == "live"
         && g.players.some(pl => pl.sid == p.sid)))
@@ -255,6 +265,14 @@ export default {
       }
       return "Challenge"; //player is available
     },
+
+// Also debug: when from game going to Hall, player appears still connected.
+// when reloading a finished (observed) game, some ghost moveToPlay errors
+
+    processChat: function(chat) {
+      // When received on server, this will trigger a "notifyRoom"
+      this.st.conn.send(JSON.stringify({code:"newchat", chat: chat}));
+    },
     sendSomethingTo: function(to, code, obj, warnDisconnected) {
       const doSend = (code, obj, sid) => {
         this.st.conn.send(JSON.stringify(Object.assign(
@@ -271,7 +289,7 @@ export default {
         if (!targetSid)
         {
           if (!!warnDisconnected)
-            alert("Warning: " + to + " is not connected");
+            alert(this.st.tr["Warning: target is not connected"]);
           return false;
         }
         else
@@ -293,21 +311,27 @@ export default {
       switch (data.code)
       {
         case "duplicate":
-          alert("Warning: duplicate 'offline' connection");
+          alert(this.st.tr["Warning: multi-tabs not supported"]);
           break;
         // 0.2] Receive clients list (just socket IDs)
         case "pollclients":
-        {
           data.sockIds.forEach(sid => {
             this.$set(this.people, sid, {id:0, name:""});
-            // Ask identity, challenges and game(s)
+            // Ask identity and challenges
             this.st.conn.send(JSON.stringify({code:"askidentity", target:sid}));
             this.st.conn.send(JSON.stringify({code:"askchallenge", target:sid}));
           });
+          break;
+        case "pollgamers":
+          // NOTE: we could make a difference between people in hall
+          // and gamers, but is it necessary?
+          data.sockIds.forEach(sid => {
+            this.$set(this.people, sid, {id:0, name:""});
+            this.st.conn.send(JSON.stringify({code:"askidentity", target:sid}));
+          });
           // Also ask current games to all playing peers (TODO: some design issue)
           this.st.conn.send(JSON.stringify({code:"askgames"}));
           break;
-        }
         case "askidentity":
         {
           // Request for identification: reply if I'm not anonymous
@@ -409,11 +433,14 @@ export default {
           }
           break;
         }
+        case "newchat":
+          this.newChat = data.chat;
+          break;
         case "refusechallenge":
         {
           ArrayFun.remove(this.challenges, c => c.id == data.cid);
           localStorage.removeItem("challenge");
-          alert(this.people[data.from].name + " declined your challenge");
+          alert(this.st.tr["Challenge declined"]);
           break;
         }
         case "deletechallenge":
@@ -424,24 +451,29 @@ export default {
           break;
         }
         case "connect":
-        {
+        case "gconnect":
           this.$set(this.people, data.from, {name:"", id:0});
           this.st.conn.send(JSON.stringify({code:"askidentity", target:data.from}));
-          this.st.conn.send(JSON.stringify({code:"askchallenge", target:data.from}));
-          this.st.conn.send(JSON.stringify({code:"askgame", target:data.from}));
+          if (data.code == "connect")
+            this.st.conn.send(JSON.stringify({code:"askchallenge", target:data.from}));
+          else
+            this.st.conn.send(JSON.stringify({code:"askgame", target:data.from}));
           break;
-        }
         case "disconnect":
-        {
           this.$delete(this.people, data.from);
-          // Also remove all challenges sent by this player:
-          ArrayFun.remove(this.challenges, c => c.from.sid == data.from);
-          // And all live games where he plays and no other opponent is online
-          ArrayFun.remove(this.games, g =>
-            g.type == "live" && (g.players.every(p => p.sid == data.from
-              || !this.people[p.sid])), "all");
+          if (data.code == "disconnect")
+          {
+            // Also remove all challenges sent by this player:
+            ArrayFun.remove(this.challenges, c => c.from.sid == data.from);
+          }
+          else
+          {
+            // And all live games where he plays and no other opponent is online
+            ArrayFun.remove(this.games, g =>
+              g.type == "live" && (g.players.every(p => p.sid == data.from
+                || !this.people[p.sid])), "all");
+          }
           break;
-        }
       }
     },
     // Challenge lifecycle:
@@ -466,7 +498,7 @@ export default {
     },
     newChallenge: async function() {
       if (this.newchallenge.vid == "")
-        return alert("Please select a variant");
+        return alert(this.st.tr["Please select a variant"]);
       const vname = this.getVname(this.newchallenge.vid);
       const vModule = await import("@/variants/" + vname + ".js");
       window.V = vModule.VariantRules;
@@ -477,7 +509,7 @@ export default {
         return alert(error);
       const ctype = this.classifyObject(this.newchallenge);
       if (ctype == "corr" && this.st.user.id <= 0)
-        return alert("Please log in to play correspondance games");
+        return alert(this.st.tr["Please log in to play correspondance games"]);
       // NOTE: "from" information is not required here
       let chall = Object.assign({}, this.newchallenge);
       const finishAddChallenge = (cid,warnDisconnected) => {
@@ -545,7 +577,7 @@ export default {
       if (!myChallenge)
       {
         if (c.type == "corr" && this.st.user.id <= 0)
-          return alert("Please log in to accept corr challenges");
+          return alert(this.st.tr["Please log in to accept corr challenges"]);
         c.accepted = true;
         if (!!c.to) //c.to == this.st.user.name (connected)
         {