Fix ajax for challenge creation

[vchess.git] / client / src / utils / ajax.js

diff --git a/client/src/utils/ajax.js b/client/src/utils/ajax.js
index 0a50a10..5b46078 100644 (file)
--- a/client/src/utils/ajax.js
+++ b/client/src/utils/ajax.js
@@ -1,5 +1,8 @@
 import params from "../parameters"; //for server URL
 
+// TODO: replace by fetch API ?
+// https://www.sitepoint.com/xmlhttprequest-vs-the-fetch-api-whats-best-for-ajax-in-2019/
+
 // From JSON (encoded string values!) to "arg1=...&arg2=..."
 function toQueryString(data)
 {
@@ -14,15 +17,16 @@ function toQueryString(data)
 export function ajax(url, method, data, success, error)
 {
        let xhr = new XMLHttpRequest();
-       if (typeof(data) === "function") //no data
+       if (data === undefined || typeof(data) === "function") //no data
        {
                error = success;
                success = data;
                data = {};
        }
+  if (!success)
+    success = () => {}; //by default, do nothing
        if (!error)
                error = errmsg => { alert(errmsg); };
-
        xhr.onreadystatechange = function() {
                if (this.readyState == 4 && this.status == 200)
                {
@@ -47,8 +51,8 @@ export function ajax(url, method, data, success, error)
        }
        xhr.open(method, params.serverUrl + url, true);
        xhr.setRequestHeader('X-Requested-With', "XMLHttpRequest");
-       // Next line because logout and authenticate set (cross-domain in dev mode) cookies
-  if (url.startsWith("/authenticate") || url.startsWith("/logout"))
+       // Next line to allow cross-domain cookies in dev mode (TODO: if...)
+  if (params.cors)
     xhr.withCredentials = true;
   if (["POST","PUT"].includes(method))
        {