Started code review + some fixes (unfinished)

[vchess.git] / client / src / data / challengeCheck.js

diff --git a/client/src/data/challengeCheck.js b/client/src/data/challengeCheck.js
index 626b7cf..789952f 100644 (file)
--- a/client/src/data/challengeCheck.js
+++ b/client/src/data/challengeCheck.js
@@ -1,29 +1,22 @@
 import { extractTime } from "@/utils/timeControl";
 
-export function checkChallenge(c)
-{
+export function checkChallenge(c) {
   const vid = parseInt(c.vid);
-  if (isNaN(vid) || vid <= 0)
-    return "Please select a variant";
+  if (isNaN(vid) || vid <= 0) return "Please select a variant";
 
   const tc = extractTime(c.cadence);
-  if (!tc)
-    return "Wrong time control";
+  if (!tc) return "Wrong time control";
 
   // Basic alphanumeric check for opponent name
-  if (!!c.to)
-  {
-     // NOTE: slightly redundant (see data/userCheck.js)
-    if (!c.to.match(/^[\w]+$/))
-      return "Wrong characters in opponent name";
+  if (c.to) {
+    // NOTE: slightly redundant (see data/userCheck.js)
+    if (!c.to.match(/^[\w]+$/)) return "Wrong characters in opponent name";
   }
 
   // Allow custom FEN (and check it) only for individual challenges
-  if (c.fen.length > 0 && !!c.to)
-  {
-    if (!V.IsGoodFen(c.fen))
-      return "Bad FEN string";
-  }
-  else
-    c.fen = "";
+  if (c.fen.length > 0 && !!c.to) {
+    if (!V.IsGoodFen(c.fen)) return "Bad FEN string";
+  } else c.fen = "";
+
+  return "";
 }