Started code review + some fixes (unfinished)
[vchess.git] / client / src / components / UpsertUser.vue
index d54014d..222a862 100644 (file)
@@ -1,33 +1,33 @@
 <template lang="pug">
 div
-  input#modalUser.modal(type="checkbox" @change="trySetEnterTime")
+  input#modalUser.modal(type="checkbox" @change="trySetEnterTime($event)")
   div(role="dialog" data-checkbox="modalUser")
     .card
       label.modal-close(for="modalUser")
-      h3 {{ stage }}
-      form#userForm(@submit.prevent="onSubmit()" @keyup.enter="onSubmit")
+      h3.section {{ st.tr[stage] }}
+      form(@submit.prevent="onSubmit()" @keyup.enter="onSubmit()")
         div(v-show="stage!='Login'")
           fieldset
-            label(for="username") {{ st.tr["Name"] }}
-            input#username(type="text" v-model="user.name")
+            label(for="username") {{ st.tr["User name"] }}
+            input#username(type="text" v-model="st.user.name")
           fieldset
             label(for="useremail") {{ st.tr["Email"] }}
-            input#useremail(type="email" v-model="user.email")
+            input#useremail(type="email" v-model="st.user.email")
           fieldset
             label(for="notifyNew") {{ st.tr["Notifications by email"] }}
-            input#notifyNew(type="checkbox" v-model="user.notify")
+            input#notifyNew(type="checkbox" v-model="st.user.notify")
         div(v-show="stage=='Login'")
           fieldset
             label(for="nameOrEmail") {{ st.tr["Name or Email"] }}
             input#nameOrEmail(type="text" v-model="nameOrEmail")
       .button-group
-        button#submit(type="button" @click="onSubmit()")
+        button(@click="onSubmit()")
           span {{ st.tr[submitMessage] }}
-        button(v-if="stage!='Update'" @click="toggleStage()")
+        button(v-if="stage!='Update'" type="button" @click="toggleStage()")
           span {{ st.tr[stage=="Login" ? "Register" : "Login"] }}
-        button#logoutBtn(v-else @click="doLogout()")
+        button(v-else type="button" @click="doLogout()")
           span {{ st.tr["Logout"] }}
-      #dialog(:style="{display: displayInfo}") {{ st.tr[infoMsg] }}
+      #dialog.text-center {{ st.tr[infoMsg] }}
 </template>
 
 <script>
@@ -35,35 +35,30 @@ import { store } from "@/store";
 import { checkNameEmail } from "@/data/userCheck";
 import { ajax } from "@/utils/ajax";
 export default {
-  name: 'my-upsert-user',
+  name: "my-upsert-user",
   data: function() {
     return {
-      user: store.state.user,
       nameOrEmail: "", //for login
       logStage: "Login", //or Register
       infoMsg: "",
       enterTime: Number.MAX_SAFE_INTEGER, //for a basic anti-bot strategy
-      st: store.state,
+      st: store.state
     };
   },
   watch: {
     nameOrEmail: function(newValue) {
-      if (newValue.indexOf('@') >= 0)
-      {
-        this.user.email = newValue;
-        this.user.name = "";
+      if (newValue.indexOf("@") >= 0) {
+        this.st.user.email = newValue;
+        this.st.user.name = "";
+      } else {
+        this.st.user.name = newValue;
+        this.st.user.email = "";
       }
-      else
-      {
-        this.user.name = newValue;
-        this.user.email = "";
-      }
-    },
+    }
   },
   computed: {
     submitMessage: function() {
-      switch (this.stage)
-      {
+      switch (this.stage) {
         case "Login":
           return "Go";
         case "Register":
@@ -71,26 +66,25 @@ export default {
         case "Update":
           return "Apply";
       }
-    },
-    displayInfo: function() {
-      return (this.infoMsg.length > 0 ? "block" : "none");
+      return "Never reached";
     },
     stage: function() {
-      return this.user.id > 0 ? "Update" : this.logStage;
-    },
+      return this.st.user.id > 0 ? "Update" : this.logStage;
+    }
   },
   methods: {
     trySetEnterTime: function(event) {
-      if (!!event.target.checked)
+      if (event.target.checked) {
+        this.infoMsg = "";
         this.enterTime = Date.now();
+      }
     },
     toggleStage: function() {
       // Loop login <--> register (update is for logged-in users)
-      this.logStage = (this.logStage == "Login" ? "Register" : "Login");
+      this.logStage = this.logStage == "Login" ? "Register" : "Login";
     },
     ajaxUrl: function() {
-      switch (this.stage)
-      {
+      switch (this.stage) {
         case "Login":
           return "/sendtoken";
         case "Register":
@@ -98,10 +92,10 @@ export default {
         case "Update":
           return "/update";
       }
+      return "Never reached";
     },
     ajaxMethod: function() {
-      switch (this.stage)
-      {
+      switch (this.stage) {
         case "Login":
           return "GET";
         case "Register":
@@ -109,44 +103,42 @@ export default {
         case "Update":
           return "PUT";
       }
+      return "Never reached";
     },
     infoMessage: function() {
-      switch (this.stage)
-      {
+      switch (this.stage) {
         case "Login":
           return "Connection token sent. Check your emails!";
         case "Register":
-          return "Registration complete! Please check your emails.";
+          return "Registration complete! Please check your emails";
         case "Update":
           return "Modifications applied!";
       }
+      return "Never reached";
     },
     onSubmit: function() {
       // Basic anti-bot strategy:
       const exitTime = Date.now();
-      if (this.stage == "Register" && exitTime - this.enterTime < 5000)
-        return; //silently return, in (curious) case of it was legitimate
+      if (this.stage == "Register" && exitTime - this.enterTime < 5000) return;
       let error = undefined;
-      if (this.stage == 'Login')
-      {
-        const type = (this.nameOrEmail.indexOf('@') >= 0 ? "email" : "name");
-        error = checkNameEmail({[type]: this.nameOrEmail});
+      if (this.stage == "Login") {
+        const type = this.nameOrEmail.indexOf("@") >= 0 ? "email" : "name";
+        error = checkNameEmail({ [type]: this.nameOrEmail });
+      } else error = checkNameEmail(this.st.user);
+      if (error) {
+        alert(error);
+        return;
       }
-      else
-        error = checkNameEmail(this.user);
-      if (!!error)
-        return alert(error);
       this.infoMsg = "Processing... Please wait";
-      ajax(this.ajaxUrl(), this.ajaxMethod(),
-        this.stage == "Login" ? { nameOrEmail: this.nameOrEmail } : this.user,
-        res => {
+      ajax(
+        this.ajaxUrl(),
+        this.ajaxMethod(),
+        this.stage == "Login"
+          ? { nameOrEmail: this.nameOrEmail }
+          : this.st.user,
+        () => {
           this.infoMsg = this.infoMessage();
-          if (this.stage != "Update")
-            this.nameOrEmail = "";
-          setTimeout(() => {
-            this.infoMsg = "";
-            document.getElementById("modalUser").checked = false;
-          }, 2000);
+          if (this.stage != "Update") this.nameOrEmail = "";
         },
         err => {
           this.infoMsg = "";
@@ -155,25 +147,18 @@ export default {
       );
     },
     doLogout: function() {
-      let logoutBtn = document.getElementById("logoutBtn");
-      logoutBtn.disabled = true;
-      // NOTE: this local cleaning would logically happen when we're sure
-      // that token is erased. But in the case a user clear the cookies,
-      // it would lead to situations where he cannot ("locally") log out.
-      // At worst, if token deletion fails the user can erase cookie manually.
-      this.user.id = 0;
-      this.user.name = "";
-      this.user.email = "";
-      this.user.notify = false;
-      localStorage.removeItem("myid");
-      localStorage.removeItem("myname");
-      ajax("/logout", "GET", () => {
-        logoutBtn.disabled = false; //for symmetry, but not very useful...
-        document.getElementById("modalUser").checked = false;
-        // this.$router.push("/") will fail if logout from Hall, so:
-        document.location.reload(true);
-      });
-    },
-  },
+      document.getElementById("modalUser").checked = false;
+      this.$router.push("/logout");
+    }
+  }
 };
 </script>
+
+<style lang="sass" scoped>
+[type="checkbox"].modal+div .card
+  max-width: 370px
+  max-height: 100%
+#dialog
+  padding: 5px
+  color: blue
+</style>