Started code review + some fixes (unfinished)

[vchess.git] / client / src / components / Settings.vue

diff --git a/client/src/components/Settings.vue b/client/src/components/Settings.vue
index 7aa0162..e5a9d9c 100644 (file)
--- a/client/src/components/Settings.vue
+++ b/client/src/components/Settings.vue
@@ -1,51 +1,57 @@
 <template lang="pug">
 div
   input#modalSettings.modal(type="checkbox")
-  div(role="dialog" aria-labelledby="settingsTitle")
-    .card.smallpad(@change="updateSettings")
+  div(role="dialog" data-checkbox="modalSettings")
+    .card(@change="updateSettings($event)")
       label.modal-close(for="modalSettings")
-      h3#settingsTitle.section {{ $tr["Preferences"] }}
-      fieldset
-        label(for="setSqSize") {{ $tr["Square size (in pixels). 0 for 'adaptative'"] }}
-        input#setSqSize(type="number" v-model="$settings.sqSize")
-      fieldset
-        label(for="selectHints") {{ $tr["Show move hints?"] }}
-        select#setHints(v-model="$settings.hints")
-          option(value="0") {{ $tr["None"] }}
-          option(value="1") {{ $tr["Moves from a square"] }}
-          option(value="2") {{ $tr["Pieces which can move"] }}
-      fieldset
-        label(for="setHighlight") {{ $tr["Highlight squares? (Last move & checks)"] }}
-        input#setHighlight(type="checkbox" v-model="$settings.highlight")
-      fieldset
-        label(for="setCoords") {{ $tr["Show board coordinates?"] }}
-        input#setCoords(type="checkbox" v-model="$settings.coords")
-      fieldset
-        label(for="selectColor") {{ $tr["Board colors"] }}
-        select#setBcolor(v-model="$settings.bcolor")
-          option(value="lichess") {{ $tr["brown"] }}
-          option(value="chesscom") {{ $tr["green"] }}
-          option(value="chesstempo") {{ $tr["blue"] }}
-      fieldset
-        label(for="selectSound") {{ $tr["Play sounds?"] }}
-        select#setSound(v-model="$settings.sound")
-          option(value="0") {{ $tr["None"] }}
-          option(value="1") {{ $tr["New game"] }}
-          option(value="2") {{ $tr["All"] }}
+      form
+        fieldset
+          label(for="setHints") {{ st.tr["Show possible moves?"] }}
+          input#setHints(type="checkbox" v-model="st.settings.hints")
+        fieldset
+          label(for="setHighlight")
+            | {{ st.tr["Highlight last move and checks?"] }}
+          input#setHighlight(type="checkbox" v-model="st.settings.highlight")
+        fieldset
+          label(for="setBcolor") {{ st.tr["Board colors"] }}
+          select#setBcolor(v-model="st.settings.bcolor")
+            option(value="lichess") {{ st.tr["brown"] }}
+            option(value="chesscom") {{ st.tr["green"] }}
+            option(value="chesstempo") {{ st.tr["blue"] }}
+        fieldset
+          label(for="setSound") {{ st.tr["Play sounds?"] }}
+          select#setSound(v-model="st.settings.sound")
+            option(value="0") {{ st.tr["None"] }}
+            option(value="1") {{ st.tr["New game"] }}
+            option(value="2") {{ st.tr["All"] }}
 </template>
 
 <script>
+import { store } from "@/store.js";
 export default {
-  name: "Settings",
-  //props: ["settings"],
-       methods: {
+  name: "my-settings",
+  data: function() {
+    return {
+      st: store.state
+    };
+  },
+  methods: {
     updateSettings: function(event) {
-      const propName =
-        event.target.id.substr(3).replace(/^\w/, c => c.toLowerCase())
-      localStorage[propName] = ["highlight","coords"].includes(propName)
-        ? event.target.checked
-        : event.target.value;
-    },
-       },
+      const propName = event.target.id
+        .substr(3)
+        .replace(/^\w/, c => c.toLowerCase());
+      let value = ["bcolor", "sound"].includes(propName)
+        ? event.target.value
+        : event.target.checked;
+      if (propName == "sound") value = parseInt(value);
+      store.updateSetting(propName, value);
+    }
+  }
 };
 </script>
+
+<style lang="sass" scoped>
+[type="checkbox"].modal+div .card
+  max-width: 767px
+  max-height: 100%
+</style>