Started code review + some fixes (unfinished)

[vchess.git] / client / src / components / MoveList.vue

diff --git a/client/src/components/MoveList.vue b/client/src/components/MoveList.vue
index 0dede66..29e9a9f 100644 (file)
--- a/client/src/components/MoveList.vue
+++ b/client/src/components/MoveList.vue
@@ -1,120 +1,97 @@
 <script>
 import { store } from "@/store";
 export default {
-  name: 'my-move-list',
-  props: ["moves","cursor","score","message","firstNum"],
+  name: "my-move-list",
+  props: ["moves", "cursor", "score", "message", "firstNum"],
   watch: {
     cursor: function(newCursor) {
-      if (window.innerWidth <= 767)
-        return; //moves list is below: scrolling would hide chessboard
+      if (window.innerWidth <= 767) return; //moves list is below: scrolling would hide chessboard
       // Count grouped moves until the cursor (if multi-moves):
       let groupsCount = -1;
       let curCol = undefined;
-      for (let i=0; i<newCursor; i++)
-      {
+      for (let i = 0; i < newCursor; i++) {
         const m = this.moves[i];
-        if (m.color != curCol)
-        {
+        if (m.color != curCol) {
           groupsCount++;
           curCol = m.color;
         }
       }
       // $nextTick to wait for table > tr to be rendered
-      this.$nextTick( () => {
-        let rows = document.querySelectorAll('#movesList tr');
-        if (rows.length > 0)
-        {
-          rows[Math.floor(Math.max(groupsCount,0)/2)].scrollIntoView({
+      this.$nextTick(() => {
+        let rows = document.querySelectorAll("#movesList tr");
+        if (rows.length > 0) {
+          rows[Math.floor(Math.max(groupsCount, 0) / 2)].scrollIntoView({
             behavior: "auto",
-            block: "nearest",
+            block: "nearest"
           });
         }
       });
-    },
+    }
   },
   render(h) {
-    if (this.moves.length == 0)
-      return;
+    if (this.moves.length == 0) return h("div");
     let tableContent = [];
     let moveCounter = 0;
     let tableRow = undefined;
     let moveCells = undefined;
     let curCellContent = "";
     let firstIndex = 0;
-    for (let i=0; i<this.moves.length; i++)
-    {
-      if (this.moves[i].color == "w")
-      {
-        if (i == 0 || i>0 && this.moves[i-1].color=="b")
-        {
-          if (!!tableRow)
-          {
+    for (let i = 0; i < this.moves.length; i++) {
+      if (this.moves[i].color == "w") {
+        if (i == 0 || (i > 0 && this.moves[i - 1].color == "b")) {
+          if (tableRow) {
             tableRow.children = moveCells;
             tableContent.push(tableRow);
           }
           moveCells = [
-            h(
-              "td",
-              { domProps: { innerHTML: (++moveCounter) + "." } }
-            )
+            h("td", { domProps: { innerHTML: ++moveCounter + "." } })
           ];
-          tableRow = h(
-            "tr",
-            { }
-          );
+          tableRow = h("tr", {});
           curCellContent = "";
           firstIndex = i;
         }
       }
       // Next condition is fine because even if the first move is black,
       // there will be the "..." which count as white move.
-      else if (this.moves[i].color == "b" && this.moves[i-1].color == "w")
+      else if (this.moves[i].color == "b" && this.moves[i - 1].color == "w")
         firstIndex = i;
       curCellContent += this.moves[i].notation;
-      if (i < this.moves.length-1 && this.moves[i+1].color == this.moves[i].color)
+      if (
+        i < this.moves.length - 1 &&
+        this.moves[i + 1].color == this.moves[i].color
+      )
         curCellContent += ",";
-      else //color change
-      {
+      //color change
+      else {
         moveCells.push(
-          h(
-            "td",
-            {
-              domProps: { innerHTML: curCellContent },
-              on: { click: () => this.gotoMove(i) },
-              "class": { "highlight-lm":
-                this.cursor >= firstIndex && this.cursor <= i },
+          h("td", {
+            domProps: { innerHTML: curCellContent },
+            on: { click: () => this.gotoMove(i) },
+            class: {
+              "highlight-lm": this.cursor >= firstIndex && this.cursor <= i
             }
-          )
+          })
         );
         curCellContent = "";
       }
     }
     // Complete last row, which might not be full:
-    if (moveCells.length-1 == 1)
-    {
-      moveCells.push(
-        h(
-          "td",
-          { domProps: { innerHTML: "" } }
-        )
-      );
+    if (moveCells.length - 1 == 1) {
+      moveCells.push(h("td", { domProps: { innerHTML: "" } }));
     }
     tableRow.children = moveCells;
     tableContent.push(tableRow);
     let rootElements = [];
-    if (!!this.score && this.score != "*")
-    {
-      const scoreDiv = h("div",
+    if (!!this.score && this.score != "*") {
+      const scoreDiv = h(
+        "div",
         {
           id: "scoreInfo",
           style: {
-            display: this.score!="*" ? "block" : "none",
-          },
+            display: this.score != "*" ? "block" : "none"
+          }
         },
-        [
-          h("p", this.score),
-          h("p", store.state.tr[this.message]),
-        ]
+        [h("p", this.score), h("p", store.state.tr[this.message])]
       );
       rootElements.push(scoreDiv);
     }
@@ -122,23 +99,20 @@ export default {
       h(
         "table",
         {
-          "class": {
-            "moves-list": true,
-          },
+          class: {
+            "moves-list": true
+          }
         },
         tableContent
       )
     );
-    return h(
-      "div",
-      { },
-      rootElements);
+    return h("div", {}, rootElements);
   },
   methods: {
     gotoMove: function(index) {
       this.$emit("goto-move", index);
-    },
-  },
+    }
+  }
 };
 </script>