Started code review + some fixes (unfinished)

[vchess.git] / client / src / components / ChallengeList.vue

diff --git a/client/src/components/ChallengeList.vue b/client/src/components/ChallengeList.vue
index bffda1a..92c42f7 100644 (file)
--- a/client/src/components/ChallengeList.vue
+++ b/client/src/components/ChallengeList.vue
@@ -5,14 +5,12 @@ div
       tr
         th {{ st.tr["Variant"] }}
         th {{ st.tr["From"] }}
-        th {{ st.tr["To"] }}
         th {{ st.tr["Cadence"] }}
     tbody
-      tr(v-for="c in sortedChallenges" @click="$emit('click-challenge',c)")
-        td(data-label="Variant") {{ c.vname }}
-        td(data-label="From") {{ c.from.name || "@nonymous" }}
-        td(data-label="To") {{ c.to }}
-        td(data-label="Cadence") {{ c.cadence }}
+      tr(v-for="c in sortedChallenges" :class="{toyou:c.priority==1,fromyou:c.priority==2}" @click="$emit('click-challenge',c)")
+        td {{ c.vname }}
+        td {{ c.from.name || "@nonymous" }}
+        td {{ c.cadence }}
 </template>
 
 <script>
@@ -22,22 +20,36 @@ export default {
   props: ["challenges"],
   data: function() {
     return {
-      st: store.state,
+      st: store.state
     };
   },
   computed: {
     sortedChallenges: function() {
       // Show in order: challenges I sent, challenges I received, other challenges
+      let minAdded = Number.MAX_SAFE_INTEGER;
+      let maxAdded = 0;
       let augmentedChalls = this.challenges.map(c => {
         let priority = 0;
-        if (c.to == this.st.user.name)
-          priority = 1;
-        else if (c.from.id == this.st.user.id || c.from.sid == this.st.user.sid)
+        if (!!c.to && c.to == this.st.user.name) priority = 1;
+        else if (c.from.sid == this.st.user.sid || c.from.id == this.st.user.id)
           priority = 2;
-        return Object.assign({}, c, {priority: priority});
+        if (c.added < minAdded) minAdded = c.added;
+        if (c.added > maxAdded) maxAdded = c.added;
+        return Object.assign({}, c, { priority: priority });
       });
-      return augmentedChalls.sort((c1,c2) => { return c2.priority - c1.priority; });
-    },
-  },
+      const deltaAdded = maxAdded - minAdded;
+      return augmentedChalls.sort((c1, c2) => {
+        return c2.priority - c1.priority + (c2.added - c1.added) / deltaAdded;
+      });
+    }
+  }
 };
 </script>
+
+<style lang="sass" scoped>
+// TODO: understand why the style applied to <tr> element doesn't work
+tr.fromyou > td
+  font-style: italic
+tr.toyou > td
+  background-color: #fcd785
+</style>