projects
/
vchess.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Some (experimental) fixes
[vchess.git]
/
client
/
src
/
views
/
Hall.vue
diff --git
a/client/src/views/Hall.vue
b/client/src/views/Hall.vue
index
c9a15ea
..
9fcc2e0
100644
(file)
--- a/
client/src/views/Hall.vue
+++ b/
client/src/views/Hall.vue
@@
-52,8
+52,8
@@
main
)
| {{ v.display }}
// Variant-specific options (often at least randomness)
)
| {{ v.display }}
// Variant-specific options (often at least randomness)
- fieldset(v-if="!!newchallenge.V")
- div(v-for="select of newchallenge.V.Options.select")
+ fieldset(v-if="!!newchallenge.V
&& newchallenge.V.Options
")
+ div(v-for="select of newchallenge.V.Options.select
|| []
")
label(:for="select.variable + '_opt'") {{ st.tr[select.label] }} *
select(:id="select.variable + '_opt'")
option(
label(:for="select.variable + '_opt'") {{ st.tr[select.label] }} *
select(:id="select.variable + '_opt'")
option(
@@
-62,7
+62,7
@@
main
:selected="o.value == select.defaut"
)
| {{ st.tr[o.label] }}
:selected="o.value == select.defaut"
)
| {{ st.tr[o.label] }}
- div(v-for="check of newchallenge.V.Options.check")
+ div(v-for="check of newchallenge.V.Options.check
|| []
")
label(:for="check.variable + '_opt'") {{ st.tr[check.label] }} *
input(
:id="check.variable + '_opt'"
label(:for="check.variable + '_opt'") {{ st.tr[check.label] }} *
input(
:id="check.variable + '_opt'"
@@
-300,10
+300,6
@@
export default {
}
},
created: function() {
}
},
created: function() {
- // TODO: remove this patch soon:
- this.presetChalls.forEach(pc => {
- if (!pc.options) pc.options = { randomness: pc.randomness };
- });
document.addEventListener('visibilitychange', this.visibilityChange);
window.addEventListener('focus', this.onFocus);
window.addEventListener('blur', this.onBlur);
document.addEventListener('visibilitychange', this.visibilityChange);
window.addEventListener('focus', this.onFocus);
window.addEventListener('blur', this.onBlur);
@@
-479,10
+475,12
@@
export default {
this.conn = null;
},
getRandomnessClass: function(pc) {
this.conn = null;
},
getRandomnessClass: function(pc) {
- if (!pc.options.randomness) return {};
- return {
- ["random-" + pc.options.randomness]: true
- };
+ const opts = pc.options;
+ if (opts.randomness === undefined && opts.random === undefined)
+ return {};
+ if (opts.randomness !== undefined)
+ return { ["random-" + opts.randomness]: true };
+ return { ["random-" + (opts.random ? 2 : 0)]: true };
},
anonymousCount: function() {
let count = 0;
},
anonymousCount: function() {
let count = 0;
@@
-850,7
+848,7
@@
export default {
id: c.id,
from: this.st.user.sid,
to: c.to,
id: c.id,
from: this.st.user.sid,
to: c.to,
- options:
c.options
,
+ options:
JSON.stringify(c.options)
,
fen: c.fen,
vid: c.vid,
cadence: c.cadence,
fen: c.fen,
vid: c.vid,
cadence: c.cadence,
@@
-909,6
+907,8
@@
export default {
if (!game.score)
// New game from Hall
newGame.score = "*";
if (!game.score)
// New game from Hall
newGame.score = "*";
+ // TODO: remove patch on next line (options || "{}")
+ newGame.options = JSON.parse(newGame.options || "{}");
this.games.push(newGame);
if (
newGame.score == '*' &&
this.games.push(newGame);
if (
newGame.score == '*' &&
@@
-929,9
+929,12
@@
export default {
}
case "startgame": {
// New game just started, I'm involved
}
case "startgame": {
// New game just started, I'm involved
- const gameInfo = data.data;
- if (this.classifyObject(gameInfo) == "live")
+ let gameInfo = data.data;
+ if (this.classifyObject(gameInfo) == "live") {
+ // TODO: remove patch on next line (+ const gameInfo)
+ if (!gameInfo.options) gameInfo.options = "{}";
this.startNewGame(gameInfo);
this.startNewGame(gameInfo);
+ }
else {
this.infoMessage =
this.st.tr["New correspondence game:"] + " " +
else {
this.infoMessage =
this.st.tr["New correspondence game:"] + " " +
@@
-975,6
+978,7
@@
export default {
let moreGames = res.games.map(g => {
this.setVname(g);
g.type = "corr";
let moreGames = res.games.map(g => {
this.setVname(g);
g.type = "corr";
+ g.options = JSON.parse(g.options);
return g;
});
this.games = this.games.concat(moreGames);
return g;
});
this.games = this.games.concat(moreGames);
@@
-994,7
+998,8
@@
export default {
) {
let newChall = Object.assign({}, chall);
newChall.type = this.classifyObject(chall);
) {
let newChall = Object.assign({}, chall);
newChall.type = this.classifyObject(chall);
- newChall.options = chall.options;
+ // TODO: remove patch on next line (options || "{}")
+ newChall.options = JSON.parse(chall.options || "{}");
newChall.added = Date.now();
let fromValues = Object.assign({}, this.people[chall.from]);
delete fromValues["pages"]; //irrelevant in this context
newChall.added = Date.now();
let fromValues = Object.assign({}, this.people[chall.from]);
delete fromValues["pages"]; //irrelevant in this context
@@
-1084,30
+1089,31
@@
export default {
error = this.st.tr["Wrong color"];
}
}
error = this.st.tr["Wrong color"];
}
}
- if (!!error) {
- alert(error);
- return;
- }
- window.V = this.newchallenge.V;
- error = checkChallenge(this.newchallenge);
if (error) {
alert(error);
return;
}
if (error) {
alert(error);
return;
}
- // NOTE: "from" information is not required here
- let chall = Object.assign({}, this.newchallenge);
- chall.options = {};
+ window.V = this.newchallenge.V;
+ let chall = Object.assign({ options: {} }, this.newchallenge);
// Get/set options variables (if any) / TODO: v-model?!
// Get/set options variables (if any) / TODO: v-model?!
- for (const check of this.newchallenge.V.Options.check) {
+ for (const check of this.newchallenge.V.Options.check
|| []
) {
const elt = document.getElementById(check.variable + "_opt");
const elt = document.getElementById(check.variable + "_opt");
-
if (elt.checked) chall.options[check.variable] = true
;
+
chall.options[check.variable] = elt.checked
;
}
}
- for (const select of this.newchallenge.V.Options.select) {
+ for (const select of this.newchallenge.V.Options.select
|| []
) {
const elt = document.getElementById(select.variable + "_opt");
const elt = document.getElementById(select.variable + "_opt");
- chall.options[select.variable] = elt.value;
+ const tryIntVal = parseInt(elt.value, 10);
+ chall.options[select.variable] =
+ (isNaN(tryIntVal) ? elt.value : tryIntVal);
+ }
+ error = checkChallenge(chall);
+ if (error) {
+ alert(this.st.tr[error]);
+ return;
}
chall.options.abridged = V.AbbreviateOptions(chall.options);
// Add only if not already issued (not counting FEN):
}
chall.options.abridged = V.AbbreviateOptions(chall.options);
// Add only if not already issued (not counting FEN):
+ // NOTE: "from" information is not required here
if (this.challenges.some(c =>
(
c.from.sid == this.st.user.sid ||
if (this.challenges.some(c =>
(
c.from.sid == this.st.user.sid ||
@@
-1169,7
+1175,10
@@
export default {
this.send("newchallenge", {
data: Object.assign(
// Temporarily add sender infos to display challenge on Discord.
this.send("newchallenge", {
data: Object.assign(
// Temporarily add sender infos to display challenge on Discord.
- { from: this.st.user.sid, sender: this.st.user.name }, chall)
+ { from: this.st.user.sid, sender: this.st.user.name },
+ chall,
+ { options: JSON.stringify(chall.options) }
+ )
});
// Add new challenge:
chall.from = {
});
// Add new challenge:
chall.from = {
@@
-1205,10
+1214,8
@@
export default {
"POST",
{
data: {
"POST",
{
data: {
- chall: Object.assign(
- {},
- chall,
- { options: JSON.stringify(chall.options) }
+ chall: Object.assign({},
+ chall, { options: JSON.stringify(chall.options) }
)
},
success: (response) => {
)
},
success: (response) => {
@@
-1317,7
+1324,7
@@
export default {
let gameInfo = {
id: getRandString(),
fen: c.fen || V.GenRandInitFen(c.options),
let gameInfo = {
id: getRandString(),
fen: c.fen || V.GenRandInitFen(c.options),
- options:
c.options
, //for rematch
+ options:
JSON.stringify(c.options)
, //for rematch
players: players,
vid: c.vid,
cadence: c.cadence
players: players,
vid: c.vid,
cadence: c.cadence
@@
-1367,11
+1374,7
@@
export default {
{
// cid is useful to delete the challenge:
data: {
{
// cid is useful to delete the challenge:
data: {
- gameInfo: Object.assign(
- {},
- gameInfo,
- { options: JSON.stringify(gameInfo.options) }
- ),
+ gameInfo: gameInfo,
cid: c.id
},
success: (response) => {
cid: c.id
},
success: (response) => {