X-Git-Url: https://git.auder.net/doc/screen_ranking.png?a=blobdiff_plain;f=public%2Fjavascripts%2Fvariants%2FCrazyhouse.js;h=bf47197d4e8347625d1791bd38bc67ce279bd84b;hb=0b7d99ecbb5dedc02cd96c457b5fc2962db9b297;hp=37337650c7bb94bf506cfd5fe8fab251eef8677f;hpb=6752407b88b6d7678b9b19df4ffe1224d17625d7;p=vchess.git

diff --git a/public/javascripts/variants/Crazyhouse.js b/public/javascripts/variants/Crazyhouse.js
index 37337650..bf47197d 100644
--- a/public/javascripts/variants/Crazyhouse.js
+++ b/public/javascripts/variants/Crazyhouse.js
@@ -4,7 +4,6 @@ class CrazyhouseRules extends ChessRules
 	{
 		super.initVariables(fen);
 		// Also init reserves (used by the interface to show landing pieces)
-		const V = VariantRules;
 		this.reserve =
 		{
 			"w":
@@ -24,53 +23,48 @@ class CrazyhouseRules extends ChessRules
 				[V.QUEEN]: 0,
 			}
 		};
-		const [sizeX,sizeY] = VariantRules.size;
-		this.promoted = doubleArray(sizeX, sizeY, false);
+		this.promoted = doubleArray(V.size.x, V.size.y, false);
 		// May be a continuation: adjust numbers of pieces in reserve + promoted pieces
 		this.moves.forEach(m => { this.updateVariables(m); });
 	}
 
 	getColor(i,j)
 	{
-		const sizeX = VariantRules.size[0];
-		if (i >= sizeX)
-			return (i==sizeX ? "w" : "b");
+		if (i >= V.size.x)
+			return (i==V.size.x ? "w" : "b");
 		return this.board[i][j].charAt(0);
 	}
 	getPiece(i,j)
 	{
-		const sizeX = VariantRules.size[0];
-		if (i >= sizeX)
-			return VariantRules.RESERVE_PIECES[j];
+		if (i >= V.size.x)
+			return V.RESERVE_PIECES[j];
 		return this.board[i][j].charAt(1);
 	}
 
 	// Used by the interface:
 	getReservePpath(color, index)
 	{
-		return color + VariantRules.RESERVE_PIECES[index];
+		return color + V.RESERVE_PIECES[index];
 	}
 
-	// Put an ordering on reserve pieces
+	// Ordering on reserve pieces
 	static get RESERVE_PIECES() {
-		const V = VariantRules;
 		return [V.PAWN,V.ROOK,V.KNIGHT,V.BISHOP,V.QUEEN];
 	}
 
 	getReserveMoves([x,y])
 	{
 		const color = this.turn;
-		const p = VariantRules.RESERVE_PIECES[y];
+		const p = V.RESERVE_PIECES[y];
 		if (this.reserve[color][p] == 0)
 			return [];
 		let moves = [];
-		const [sizeX,sizeY] = VariantRules.size;
-		const pawnShift = (p==VariantRules.PAWN ? 1 : 0);
-		for (let i=pawnShift; i<sizeX-pawnShift; i++)
+		const pawnShift = (p==V.PAWN ? 1 : 0);
+		for (let i=pawnShift; i<V.size.x-pawnShift; i++)
 		{
-			for (let j=0; j<sizeY; j++)
+			for (let j=0; j<V.size.y; j++)
 			{
-				if (this.board[i][j] == VariantRules.EMPTY)
+				if (this.board[i][j] == V.EMPTY)
 				{
 					let mv = new Move({
 						appear: [
@@ -94,10 +88,9 @@ class CrazyhouseRules extends ChessRules
 
 	getPotentialMovesFrom([x,y])
 	{
-		const sizeX = VariantRules.size[0];
-		if (x >= sizeX)
+		if (x >= V.size.x)
 		{
-			// Reserves, outside of board: x == sizeX
+			// Reserves, outside of board: x == sizeX(+1)
 			return this.getReserveMoves([x,y]);
 		}
 		// Standard moves
@@ -108,9 +101,8 @@ class CrazyhouseRules extends ChessRules
 	{
 		let moves = super.getAllValidMoves();
 		const color = this.turn;
-		const sizeX = VariantRules.size[0];
-		for (let i=0; i<VariantRules.RESERVE_PIECES.length; i++)
-			moves = moves.concat(this.getReserveMoves([sizeX+(color=="w"?0:1),i]));
+		for (let i=0; i<V.RESERVE_PIECES.length; i++)
+			moves = moves.concat(this.getReserveMoves([V.size.x+(color=="w"?0:1),i]));
 		return this.filterValid(moves);
 	}
 
@@ -118,11 +110,12 @@ class CrazyhouseRules extends ChessRules
 	{
 		if (!super.atLeastOneMove())
 		{
-			const sizeX = VariantRules.size[0];
-			// Scan for reserve moves
-			for (let i=0; i<VariantRules.RESERVE_PIECES.length; i++)
+			const color = this.turn;
+			// Search one reserve move
+			for (let i=0; i<V.RESERVE_PIECES.length; i++)
 			{
-				let moves = this.filterValid(this.getReserveMoves([sizeX,i]));
+				let moves = this.filterValid(
+					this.getReserveMoves([V.size.x+(this.turn=="w"?0:1), i]) );
 				if (moves.length > 0)
 					return true;
 			}
@@ -137,81 +130,40 @@ class CrazyhouseRules extends ChessRules
 		if (move.vanish.length == 2 && move.appear.length == 2)
 			return; //skip castle
 		const color = this.turn;
-		const V = VariantRules;
-		// Three types of move:
-		//   1. Rebirth: just update material
-		//   2. Standard move:
-		//     a. check if a promoted piece is moving
-		//     b. check if it's a promotion (mutually exclusive)
-		//   3. Capture:
-		//     a. check if a promoted piece is captured (and mark move)
-		//     b. check if a promoted piece is moving
-		//     c. check if it's a promotion (mutually exclusive with b)
 		if (move.vanish.length == 0)
-			this.reserve[color][move.appear[0].p]--;
-		else if (move.vanish.length == 1)
-		{
-			if (this.promoted[move.start.x][move.start.y])
-			{
-				this.promoted[move.start.x][move.start.y] = false;
-				this.promoted[move.end.x][move.end.y] = true;
-			}
-			else if (move.vanish[0].p == V.PAWN && move.appear[0].p != V.PAWN)
-				this.promoted[move.end.x][move.end.y] = true;
-		}
-		else //capture
 		{
-			if (this.promoted[move.end.x][move.end.y])
-			{
-				move.capturePromoted = true; //required for undo
-				this.reserve[color][VariantRules.PAWN]++;
-				this.promoted[move.end.x][move.end.y] = false;
-			}
-			else
-				this.reserve[color][move.vanish[1].p]++;
-			if (this.promoted[move.start.x][move.start.y])
-			{
-				this.promoted[move.start.x][move.start.y] = false;
-				this.promoted[move.end.x][move.end.y] = true;
-			}
-			else if (move.vanish[0].p == V.PAWN && move.appear[0].p != V.PAWN)
-				this.promoted[move.end.x][move.end.y] = true;
+			this.reserve[color][move.appear[0].p]--;
+			return;
 		}
+		move.movePromoted = this.promoted[move.start.x][move.start.y];
+		move.capturePromoted = this.promoted[move.end.x][move.end.y]
+		this.promoted[move.start.x][move.start.y] = false;
+		this.promoted[move.end.x][move.end.y] = move.movePromoted
+			|| (move.vanish[0].p == V.PAWN && move.appear[0].p != V.PAWN);
+		if (move.capturePromoted)
+			this.reserve[color][V.PAWN]++;
+		else if (move.vanish.length == 2)
+			this.reserve[color][move.vanish[1].p]++;
 	}
 
 	unupdateVariables(move)
 	{
 		super.unupdateVariables(move);
+		if (move.vanish.length == 2 && move.appear.length == 2)
+			return;
 		const color = this.turn;
-		const V = VariantRules;
 		if (move.vanish.length == 0)
-			this.reserve[color][move.appear[0].p]++;
-		else if (move.vanish.length == 1)
-		{
-			if (this.promoted[move.end.x][move.end.y])
-			{
-				this.promoted[move.end.x][move.end.y] = false;
-				if (move.vanish[0].p != V.PAWN || move.appear[0].p == V.PAWN)
-				{
-					// Not a promotion (= promoted piece creation)
-					this.promoted[move.start.x][move.start.y] = true;
-				}
-			}
-		}
-		else //capture
 		{
-			if (this.promoted[move.end.x][move.end.y])
-			{
-				this.promoted[move.end.x][move.end.y] = !!move.capturePromoted;
-				if (move.vanish[0].p != V.PAWN || move.appear[0].p == V.PAWN)
-					this.promoted[move.start.x][move.start.y] = true;
-			}
-			// Un-update material:
-			if (move.capturePromoted)
-				this.reserve[color][VariantRules.PAWN]--;
-			else
-				this.reserve[color][move.vanish[1].p]--;
+			this.reserve[color][move.appear[0].p]++;
+			return;
 		}
+		if (move.movePromoted)
+			this.promoted[move.start.x][move.start.y] = true;
+		this.promoted[move.end.x][move.end.y] = move.capturePromoted;
+		if (move.capturePromoted)
+			this.reserve[color][V.PAWN]--;
+		else if (move.vanish.length == 2)
+			this.reserve[color][move.vanish[1].p]--;
 	}
 
 	static get SEARCH_DEPTH() { return 2; } //high branching factor
@@ -220,11 +172,11 @@ class CrazyhouseRules extends ChessRules
 	{
 		let evaluation = super.evalPosition();
 		// Add reserves:
-		for (let i=0; i<VariantRules.RESERVE_PIECES.length; i++)
+		for (let i=0; i<V.RESERVE_PIECES.length; i++)
 		{
-			const p = VariantRules.RESERVE_PIECES[i];
-			evaluation += this.reserve["w"][p] * VariantRules.VALUES[p];
-			evaluation -= this.reserve["b"][p] * VariantRules.VALUES[p];
+			const p = V.RESERVE_PIECES[i];
+			evaluation += this.reserve["w"][p] * V.VALUES[p];
+			evaluation -= this.reserve["b"][p] * V.VALUES[p];
 		}
 		return evaluation;
 	}
@@ -235,9 +187,9 @@ class CrazyhouseRules extends ChessRules
 			return super.getNotation(move);
 		// Rebirth:
 		const piece =
-			(move.appear[0].p != VariantRules.PAWN ? move.appear[0].p.toUpperCase() : "");
+			(move.appear[0].p != V.PAWN ? move.appear[0].p.toUpperCase() : "");
 		const finalSquare =
-			String.fromCharCode(97 + move.end.y) + (VariantRules.size[0]-move.end.x);
+			String.fromCharCode(97 + move.end.y) + (V.size.x-move.end.x);
 		return piece + "@" + finalSquare;
 	}
 
@@ -246,7 +198,7 @@ class CrazyhouseRules extends ChessRules
 		if (move.vanish.length > 0)
 			return super.getLongNotation(move);
 		const finalSquare =
-			String.fromCharCode(97 + move.end.y) + (VariantRules.size[0]-move.end.x);
+			String.fromCharCode(97 + move.end.y) + (V.size.x-move.end.x);
 		return "@" + finalSquare;
 	}
 }