From f1c9d7072d253ba55a941f97a99eee7e394577ed Mon Sep 17 00:00:00 2001 From: Benjamin Auder Date: Tue, 17 Mar 2020 11:40:32 +0100 Subject: [PATCH] Move 'anonymousCount' which was computed to a method in Hall. Seems more accurate --- client/src/components/BaseGame.vue | 2 +- client/src/views/Hall.vue | 20 +++++++++----------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/client/src/components/BaseGame.vue b/client/src/components/BaseGame.vue index 612ded48..4162dfca 100644 --- a/client/src/components/BaseGame.vue +++ b/client/src/components/BaseGame.vue @@ -291,7 +291,7 @@ export default { if (this.game.mode == "analyze") { this.$emit( "fenchange", - this.lastMove ? this.lastMove.fen : this.game.fenStart + !!this.lastMove ? this.lastMove.fen : this.game.fenStart ); } }, diff --git a/client/src/views/Hall.vue b/client/src/views/Hall.vue index eb8464ae..8f86f4c4 100644 --- a/client/src/views/Hall.vue +++ b/client/src/views/Hall.vue @@ -120,7 +120,7 @@ main @click="challenge(sid)" ) | {{ st.tr["Challenge"] }} - p.anonymous @nonymous ({{ anonymousCount }}) + p.anonymous @nonymous ({{ anonymousCount() }}) #chat Chat( :newChat="newChat" @@ -266,16 +266,6 @@ export default { this.loadNewchallVariant(); } }, - computed: { - anonymousCount: function() { - let count = 0; - Object.values(this.people).forEach(p => { - // Do not cound people who did not send their identity yet: - count += (!p.name && p.id === 0) ? 1 : 0; - }); - return count; - } - }, created: function() { if (this.st.variants.length > 0 && this.newchallenge.vid > 0) this.loadNewchallVariant(); @@ -436,6 +426,14 @@ export default { ["random-" + pc.randomness]: true }; }, + anonymousCount: function() { + let count = 0; + Object.values(this.people).forEach(p => { + // Do not cound people who did not send their identity yet: + count += (!p.name && p.id === 0) ? 1 : 0; + }); + return count; + }, visibilityChange: function() { // TODO: Use document.hidden? https://webplatform.news/issues/2019-03-27 this.send( -- 2.44.0