X-Git-Url: https://git.auder.net/?p=vchess.git;a=blobdiff_plain;f=client%2Fsrc%2Fviews%2FHall.vue;h=94a7bbad1d9f59f3288c5d0c775a393d68699384;hp=05ee05b5debc20f92ada66bf28fe82457772dadc;hb=bae751bc6bc548791772c3ff5883a03deeb77264;hpb=bcc745f8339186cb7bdbfb4be72c457a2a373bff diff --git a/client/src/views/Hall.vue b/client/src/views/Hall.vue index 05ee05b5..94a7bbad 100644 --- a/client/src/views/Hall.vue +++ b/client/src/views/Hall.vue @@ -52,8 +52,8 @@ main ) | {{ v.display }} // Variant-specific options (often at least randomness) - fieldset(v-if="!!newchallenge.V") - div(v-for="select of newchallenge.V.Options.select") + fieldset(v-if="!!newchallenge.V && newchallenge.V.Options") + div(v-for="select of newchallenge.V.Options.select || []") label(:for="select.variable + '_opt'") {{ st.tr[select.label] }} * select(:id="select.variable + '_opt'") option( @@ -62,7 +62,7 @@ main :selected="o.value == select.defaut" ) | {{ st.tr[o.label] }} - div(v-for="check of newchallenge.V.Options.check") + div(v-for="check of newchallenge.V.Options.check || []") label(:for="check.variable + '_opt'") {{ st.tr[check.label] }} * input( :id="check.variable + '_opt'" @@ -172,9 +172,11 @@ main th {{ st.tr["Options"] }} th tbody + // TODO: remove the check !!pc.options tr( v-for="pc in presetChalls" @click="newChallFromPreset(pc)" + v-if="!!pc.options" ) td {{ pc.vname }} td {{ pc.cadence }} @@ -300,10 +302,6 @@ export default { } }, created: function() { - // TODO: remove this patch soon: - this.presetChalls.forEach(pc => { - if (!pc.options) pc.options = { randomness: pc.randomness }; - }); document.addEventListener('visibilitychange', this.visibilityChange); window.addEventListener('focus', this.onFocus); window.addEventListener('blur', this.onBlur); @@ -319,7 +317,7 @@ export default { id: my.id, name: my.name, tmpIds: { - tmpId: { page: "/", focus: true } + [tmpId]: { page: "/", focus: true } } } ); @@ -479,16 +477,12 @@ export default { this.conn = null; }, getRandomnessClass: function(pc) { - if ( - // TODO: one extra test here - !Number.isInteger(pc.options.randomness) && - !parseInt(pc.options.randomness, 10) - ) { + const opts = pc.options; + if (opts.randomness === undefined && opts.random === undefined) return {}; - } - return { - ["random-" + pc.options.randomness]: true - }; + if (opts.randomness !== undefined) + return { ["random-" + opts.randomness]: true }; + return { ["random-" + (opts.random ? 2 : 0)]: true }; }, anonymousCount: function() { let count = 0; @@ -513,7 +507,7 @@ export default { }, invColor: function(c) { if (c == 'w') return this.st.tr["Black"]; - return this.tr.tr["White"]; + return this.st.tr["White"]; }, partialResetNewchallenge: function() { // Reset potential target and custom FEN: @@ -856,7 +850,7 @@ export default { id: c.id, from: this.st.user.sid, to: c.to, - options: c.options, + options: JSON.stringify(c.options), fen: c.fen, vid: c.vid, cadence: c.cadence, @@ -915,6 +909,8 @@ export default { if (!game.score) // New game from Hall newGame.score = "*"; + // TODO: remove patch on next line (options || "{}") + newGame.options = JSON.parse(newGame.options || "{}"); this.games.push(newGame); if ( newGame.score == '*' && @@ -935,9 +931,12 @@ export default { } case "startgame": { // New game just started, I'm involved - const gameInfo = data.data; - if (this.classifyObject(gameInfo) == "live") + let gameInfo = data.data; + if (this.classifyObject(gameInfo) == "live") { + // TODO: remove patch on next line (+ const gameInfo) + if (!gameInfo.options) gameInfo.options = "{}"; this.startNewGame(gameInfo); + } else { this.infoMessage = this.st.tr["New correspondence game:"] + " " + @@ -981,6 +980,7 @@ export default { let moreGames = res.games.map(g => { this.setVname(g); g.type = "corr"; + g.options = JSON.parse(g.options); return g; }); this.games = this.games.concat(moreGames); @@ -1000,7 +1000,8 @@ export default { ) { let newChall = Object.assign({}, chall); newChall.type = this.classifyObject(chall); - newChall.options = chall.options; + // TODO: remove patch on next line (options || "{}") + newChall.options = JSON.parse(chall.options || "{}"); newChall.added = Date.now(); let fromValues = Object.assign({}, this.people[chall.from]); delete fromValues["pages"]; //irrelevant in this context @@ -1060,6 +1061,7 @@ export default { this.newchallenge.vid = pchall.vid; this.newchallenge.cadence = pchall.cadence; this.newchallenge.options = pchall.options; + this.newchallenge.fromPreset = true; this.loadNewchallVariant(this.issueNewChallenge); }, issueNewChallenge: async function() { @@ -1090,30 +1092,34 @@ export default { error = this.st.tr["Wrong color"]; } } - if (!!error) { - alert(error); - return; - } - window.V = this.newchallenge.V; - error = checkChallenge(this.newchallenge); if (error) { alert(error); return; } - // NOTE: "from" information is not required here + window.V = this.newchallenge.V; let chall = Object.assign({}, this.newchallenge); - chall.options = {}; - // Get/set options variables (if any) / TODO: v-model?! - for (const check of this.newchallenge.V.Options.check) { - const elt = document.getElementById(check.variable + "_opt"); - if (elt.checked) chall.options[check.variable] = true; + if (!this.newchallenge.fromPreset) chall.options = { options: {} }; + if (V.Options && !this.newchallenge.fromPreset) { + // Get/set options variables (if any) / TODO: v-model?! + for (const check of this.newchallenge.V.Options.check || []) { + const elt = document.getElementById(check.variable + "_opt"); + chall.options[check.variable] = elt.checked; + } + for (const select of this.newchallenge.V.Options.select || []) { + const elt = document.getElementById(select.variable + "_opt"); + const tryIntVal = parseInt(elt.value, 10); + chall.options[select.variable] = + (isNaN(tryIntVal) ? elt.value : tryIntVal); + } } - for (const select of this.newchallenge.V.Options.select) { - const elt = document.getElementById(select.variable + "_opt"); - chall.options[select.variable] = elt.value; + error = checkChallenge(chall); + if (error) { + alert(this.st.tr[error]); + return; } chall.options.abridged = V.AbbreviateOptions(chall.options); // Add only if not already issued (not counting FEN): + // NOTE: "from" information is not required here if (this.challenges.some(c => ( c.from.sid == this.st.user.sid || @@ -1132,7 +1138,7 @@ export default { alert(this.st.tr["Challenge already exists"]); return; } - if (this.newchallenge.memorize) this.addPresetChall(this.newchallenge); + if (this.newchallenge.memorize) this.addPresetChall(chall); delete chall["V"]; delete chall["diag"]; const finishAddChallenge = cid => { @@ -1175,7 +1181,10 @@ export default { this.send("newchallenge", { data: Object.assign( // Temporarily add sender infos to display challenge on Discord. - { from: this.st.user.sid, sender: this.st.user.name }, chall) + { from: this.st.user.sid, sender: this.st.user.name }, + chall, + { options: JSON.stringify(chall.options) } + ) }); // Add new challenge: chall.from = { @@ -1323,7 +1332,7 @@ export default { let gameInfo = { id: getRandString(), fen: c.fen || V.GenRandInitFen(c.options), - options: c.options, //for rematch + options: JSON.stringify(c.options), //for rematch players: players, vid: c.vid, cadence: c.cadence @@ -1373,11 +1382,7 @@ export default { { // cid is useful to delete the challenge: data: { - gameInfo: Object.assign( - {}, - gameInfo, - { options: JSON.stringify(gameInfo.options) } - ), + gameInfo: gameInfo, cid: c.id }, success: (response) => { @@ -1403,8 +1408,7 @@ export default { moves: [], clocks: [-1, -1], //-1 = unstarted chats: [], - score: "*", - options: JSON.stringify(gameInfo.options) + score: "*" } ); setTimeout( @@ -1476,8 +1480,8 @@ div#peopleWrap > .card #chat > .card max-width: 100% - margin: 0; - border: none; + margin: 0 + border: none #players > p margin-left: 5px