X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=server%2Fsockets.js;h=e6e85ed45e9860d477e78d21fe2e7cd3b24db7b2;hb=e5c1d0fb0ed18632e9172c932d6e5c2c8c5742b8;hp=11f7d8ec50a348364c73502709e45fa8e9da262b;hpb=8418f0d79395f40172b11d62eef8b83112f1d240;p=vchess.git diff --git a/server/sockets.js b/server/sockets.js index 11f7d8ec..e6e85ed4 100644 --- a/server/sockets.js +++ b/server/sockets.js @@ -2,8 +2,7 @@ const url = require('url'); // Node version in Ubuntu 16.04 does not know about URL class // NOTE: url is already transformed, without ?xxx=yyy... parts -function getJsonFromUrl(url) -{ +function getJsonFromUrl(url) { const query = url.substr(2); //starts with "/?" let result = {}; query.split("&").forEach((part) => { @@ -13,8 +12,14 @@ function getJsonFromUrl(url) return result; } +// Helper to safe-send some message through a (web-)socket: +function send(socket, message) { + if (!!socket && socket.readyState == 1) + socket.send(JSON.stringify(message)); +} + module.exports = function(wss) { - // Associative array sid --> tmpId --> {socket, page}, + // Associative array page --> sid --> tmpId --> socket // "page" is either "/" for hall or "/game/some_gid" for Game, // tmpId is required if a same user (browser) has different tabs let clients = {}; @@ -22,217 +27,246 @@ module.exports = function(wss) { const query = getJsonFromUrl(req.url); const sid = query["sid"]; const tmpId = query["tmpId"]; - const notifyRoom = (page,code,obj={},excluded=[]) => { - Object.keys(clients).forEach(k => { - if (k in excluded) - return; - if (k != sid && clients[k].page == page) - { - clients[k].sock.send(JSON.stringify(Object.assign( - {code:code, from:[sid,tmpId]}, obj))); - } + const page = query["page"]; + const notifyRoom = (page,code,obj={}) => { + if (!clients[page]) return; + Object.keys(clients[page]).forEach(k => { + Object.keys(clients[page][k]).forEach(x => { + if (k == sid && x == tmpId) return; + send( + clients[page][k][x], + Object.assign({code: code, from: sid}, obj) + ); + }); }); }; + const deleteConnexion = () => { + if (!clients[page] || !clients[page][sid] || !clients[page][sid][tmpId]) + return; //job already done + delete clients[page][sid][tmpId]; + if (Object.keys(clients[page][sid]).length == 0) { + delete clients[page][sid]; + if (Object.keys(clients[page]).length == 0) + delete clients[page]; + } + }; + + const doDisconnect = () => { + deleteConnexion(); + if (!clients[page] || !clients[page][sid]) { + // I effectively disconnected from this page: + notifyRoom(page, "disconnect"); + if (page.indexOf("/game/") >= 0) + notifyRoom("/", "gdisconnect", {page:page}); + } + }; const messageListener = (objtxt) => { let obj = JSON.parse(objtxt); - if (!!obj.target && !clients[obj.target]) - return; //receiver not connected, nothing we can do - switch (obj.code) - { + switch (obj.code) { // Wait for "connect" message to notify connection to the room, // because if game loading is slow the message listener might // not be ready too early. - case "connect": - { - const curPage = clients[sid][tmpId].page; - notifyRoom(curPage, "connect"); //Hall or Game - if (curPage.indexOf("/game/") >= 0) - notifyRoom("/", "gconnect"); //notify main hall + case "connect": { + notifyRoom(page, "connect"); + if (page.indexOf("/game/") >= 0) + notifyRoom("/", "gconnect", {page:page}); break; } case "disconnect": - { - const oldPage = obj.page; - notifyRoom(oldPage, "disconnect"); //Hall or Game - if (oldPage.indexOf("/game/") >= 0) - notifyRoom("/", "gdisconnect"); //notify main hall + // When page changes: + doDisconnect(); break; - } - case "pollclients": - { - const curPage = clients[sid][tmpId].page; - let sockIds = {}; //result, object sid ==> [tmpIds] - Object.keys(clients).forEach(k => { - Object.keys(clients[k]).forEach(x => { - if ((k != sid || x != tmpId) - && clients[k][x].page == curPage) - { - if (!sockIds[k]) - sockIds[k] = [x]; - else - sockIds[k].push(x); + case "killme": { + // Self multi-connect: manual removal + disconnect + const doKill = (pg) => { + Object.keys(clients[pg][obj.sid]).forEach(x => { + send(clients[pg][obj.sid][x], {code: "killed"}); + }); + delete clients[pg][obj.sid]; + }; + const disconnectFromOtherConnexion = (pg,code,o={}) => { + Object.keys(clients[pg]).forEach(k => { + if (k != obj.sid) { + Object.keys(clients[pg][k]).forEach(x => { + send( + clients[pg][k][x], + Object.assign({code: code, from: obj.sid}, o) + ); + }); } }); + }; + Object.keys(clients).forEach(pg => { + if (clients[pg][obj.sid]) { + doKill(pg); + disconnectFromOtherConnexion(pg, "disconnect"); + if (pg.indexOf("/game/") >= 0 && clients["/"]) + disconnectFromOtherConnexion("/", "gdisconnect", {page: pg}); + } }); - socket.send(JSON.stringify({code:"pollclients", sockIds:sockIds})); break; } - case "pollgamers": - { - let sockIds = {}; - Object.keys(clients).forEach(k => { - Object.keys(clients[k]).forEach(x => { - if ((k != sid || x != tmpId) - && clients[k][x].page.indexOf("/game/") >= 0) - { - if (!sockIds[k]) - sockIds[k] = [x]; - else - sockIds[k].push(x); - } - }); + case "pollclients": { + // From Hall or Game + let sockIds = []; + Object.keys(clients[page]).forEach(k => { + // Avoid polling myself: no new information to get + if (k != sid) sockIds.push(k); }); - socket.send(JSON.stringify({code:"pollgamers", sockIds:sockIds})); + send(socket, {code: "pollclients", sockIds: sockIds}); break; } - case "askidentity": - { - // Identity only depends on sid, so select a tmpId at random - const tmpIds = Object.keys(clients[obj.target]); - const tmpId_idx = Math.floor(Math.random() * tmpIds.length); - clients[obj.target][tmpIds[tmpId_idx]].sock.send(JSON.stringify( - {code:"askidentity",from:[sid,tmpId]})); + case "pollclientsandgamers": { + // From Hall + let sockIds = []; + Object.keys(clients["/"]).forEach(k => { + // Avoid polling myself: no new information to get + if (k != sid) sockIds.push({sid:k}); + }); + // NOTE: a "gamer" could also just be an observer + Object.keys(clients).forEach(p => { + if (p != "/") { + Object.keys(clients[p]).forEach(k => { + // 'page' indicator is needed for gamers + if (k != sid) sockIds.push({sid:k, page:p}); + }); + } + }); + send(socket, {code: "pollclientsandgamers", sockIds: sockIds}); break; } + + // Asking something: from is fully identified, + // but the requested resource can be from any tmpId (except current!) + case "askidentity": case "asklastate": - clients[obj.target[0]][obj.target[1]].sock.send(JSON.stringify( - {code:"asklastate",from:[sid,tmpId]})); - break; case "askchallenge": - clients[obj.target[0]][obj.target[1]].sock.send(JSON.stringify( - {code:"askchallenge",from:[sid,tmpId]})); - break; - case "askgames": - { - // Check all clients playing, and send them a "askgame" message - // game ID --> [ sid1 --> array of tmpIds, sid2 --> array of tmpIds] - let gameSids = {}; - const regexpGid = /\/[a-zA-Z0-9]+$/; - Object.keys(clients).forEach(k => { - Object.keys(clients[k]).forEach(x => { - if ((k != sid || x != tmpId) - && clients[k][x].page.indexOf("/game/") >= 0) - { - const gid = clients[k][x].page.match(regexpGid)[0]; - if (!gameSids[gid]) - gameSids[gid] = [{k: [x]}]; - else if (k == Object.keys(gameSids[gid][0])[0]) - gameSids[gid][0][k].push(x); - else if (gameSids[gid].length == 1) - gameSids[gid].push({k: [x]}); - else - Object.values(gameSids[gid][1]).push(x); + case "askgame": + case "askfullgame": { + const pg = obj.page || page; //required for askidentity and askgame + // In cas askfullgame to wrong SID for example, would crash: + if (!!clients[pg] && !!clients[pg][obj.target]) { + const tmpIds = Object.keys(clients[pg][obj.target]); + if (obj.target == sid) { + // Targetting myself + const idx_myTmpid = tmpIds.findIndex(x => x == tmpId); + if (idx_myTmpid >= 0) tmpIds.splice(idx_myTmpid, 1); } - }); - // Request only one client out of 2 (TODO: this is a bit heavy) - // Alt: ask game to all, and filter later? - Object.keys(gameSids).forEach(gid => { - const L = gameSids[gid].length; - const sidIdx = L > 1 - ? Math.floor(Math.random() * Math.floor(L)) - : 0; - const tmpIdx = Object.values(gameSids[gid][sidIdx] - const rid = gameSids[gid][sidIdx][tmpIdx]; - clients[sidIdx][tmpIdx].sock.send(JSON.stringify( - {code:"askgame", from: [sid,tmpId]})); - }); + const tmpId_idx = Math.floor(Math.random() * tmpIds.length); + send( + clients[pg][obj.target][tmpIds[tmpId_idx]], + {code: obj.code, from: [sid,tmpId,page]} + ); + } break; } - case "askgame": - clients[obj.target].sock.send(JSON.stringify( - {code:"askgame", from:sid})); - break; - case "askfullgame": - clients[obj.target].sock.send(JSON.stringify( - {code:"askfullgame", from:sid})); - break; - case "fullgame": - clients[obj.target].sock.send(JSON.stringify( - {code:"fullgame", game:obj.game})); - break; - case "identity": - clients[obj.target].sock.send(JSON.stringify( - {code:"identity",user:obj.user})); - break; + + // Some Hall events: target all tmpId's (except mine), case "refusechallenge": - clients[obj.target].sock.send(JSON.stringify( - {code:"refusechallenge", cid:obj.cid, from:sid})); - break; - case "deletechallenge": - clients[obj.target].sock.send(JSON.stringify( - {code:"deletechallenge", cid:obj.cid, from:sid})); + case "startgame": + Object.keys(clients[page][obj.target]).forEach(x => { + if (obj.target != sid || x != tmpId) + send( + clients[page][obj.target][x], + {code: obj.code, data: obj.data} + ); + }); break; + + // Notify all room: mostly game events + case "newchat": + case "newchallenge": case "newgame": - clients[obj.target].sock.send(JSON.stringify( - {code:"newgame", gameInfo:obj.gameInfo, cid:obj.cid})); - break; - case "challenge": - clients[obj.target].sock.send(JSON.stringify( - {code:"challenge", chall:obj.chall, from:sid})); + case "deletechallenge": + case "resign": + case "abort": + case "drawoffer": + case "draw": + notifyRoom(page, obj.code, {data: obj.data}); break; - case "game": - if (!!obj.target) - { - clients[obj.target].sock.send(JSON.stringify( - {code:"game", game:obj.game, from:sid})); - } - else - { - // Notify all room except opponent and me: - notifyRoom("/", "game", {game:obj.game}, [obj.oppsid]); + + case "newmove": { + const dataWithFrom = {from: [sid,tmpId], data: obj.data}; + // Special case re-send newmove only to opponent: + if (!!obj.target && !!clients[page][obj.target]) { + Object.keys(clients[page][obj.target]).forEach(x => { + send( + clients[page][obj.target][x], + {code: "newmove", dataWithFrom} + ); + }); + } else { + // NOTE: data.from is useful only to opponent + notifyRoom(page, "newmove", dataWithFrom); } break; - case "newchat": - notifyRoom(clients[sid].page, "newchat", {chat:obj.chat}); - break; - // TODO: WebRTC instead in this case (most demanding?) - // --> Or else: at least do a "notifyRoom" (also for draw, resign...) - case "newmove": - clients[obj.target].sock.send(JSON.stringify( - {code:"newmove", move:obj.move})); - break; - case "lastate": - clients[obj.target].sock.send(JSON.stringify( - {code:"lastate", state:obj.state})); + } + case "gotmove": + if ( + !!clients[page][obj.target[0]] && + !!clients[page][obj.target[0]][obj.target[1]] + ) { + send( + clients[page][obj.target[0]][obj.target[1]], + {code: "gotmove", data: obj.data} + ); + } break; - case "resign": - clients[obj.target].sock.send(JSON.stringify( - {code:"resign", side:obj.side})); + + case "result": + // Special case: notify all, 'transroom': Game --> Hall + notifyRoom("/", "result", {gid: obj.gid, score: obj.score}); break; - case "abort": - clients[obj.target].sock.send(JSON.stringify( - {code:"abort"})); + + case "mconnect": + // Special case: notify some game rooms that + // I'm watching game state from MyGames + // TODO: this code is ignored for now + obj.gids.forEach(gid => { + const pg = "/game/" + gid; + Object.keys(clients[pg]).forEach(s => { + Object.keys(clients[pg][s]).forEach(x => { + send( + clients[pg][s][x], + {code: "mconnect", data: obj.data} + ); + }); + }); + }); break; - case "drawoffer": - clients[obj.target].sock.send(JSON.stringify( - {code:"drawoffer"})); + case "mdisconnect": + // TODO + // Also TODO: pass newgame to MyGames, and gameover (result) break; - case "draw": - clients[obj.target].sock.send(JSON.stringify( - {code:"draw", message:obj.message})); + + // Passing, relaying something: from isn't needed, + // but target is fully identified (sid + tmpId) + case "challenge": + case "fullgame": + case "game": + case "identity": + case "lastate": + { + const pg = obj.target[2] || page; //required for identity and game + // NOTE: if in game we ask identity to opponent still in Hall, + // but leaving Hall, clients[pg] or clients[pg][target] could be undefined + if (!!clients[pg] && !!clients[pg][obj.target[0]]) + send(clients[pg][obj.target[0]][obj.target[1]], {code:obj.code, data:obj.data}); break; + } } }; const closeListener = () => { - delete clients[sid]; + // For browser or tab closing (including page reload): + doDisconnect(); }; - if (!!clients[sid]) - { - // Turn off old sock through current client: - clients[sid].sock.send(JSON.stringify({code:"duplicate"})); - } - // Potentially replace current connection: - clients[sid] = {sock: socket, page: query["page"]}; + // Update clients object: add new connexion + if (!clients[page]) + clients[page] = {[sid]: {[tmpId]: socket}}; + else if (!clients[page][sid]) + clients[page][sid] = {[tmpId]: socket}; + else + clients[page][sid][tmpId] = socket; socket.on("message", messageListener); socket.on("close", closeListener); });