X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=server%2Froutes%2Fchallenges.js;h=28103fce50ff2ef7b3085f7ad15d449a11a13280;hb=fe4c7e67075416c48aafe9e307bef5afea7937bc;hp=c85c60986cf4472ca46554d9653735f92d451922;hpb=f4f4c03ccf97e82bbab8ee4af01445057403f1a2;p=vchess.git

diff --git a/server/routes/challenges.js b/server/routes/challenges.js
index c85c6098..28103fce 100644
--- a/server/routes/challenges.js
+++ b/server/routes/challenges.js
@@ -3,70 +3,52 @@
 let router = require("express").Router();
 const access = require("../utils/access");
 const ChallengeModel = require("../models/Challenge");
+const UserModel = require("../models/User"); //for name check
+const params = require("../config/parameters");
 
-router.post("/challenges/:vid([0-9]+)", access.logged, access.ajax, (req,res) => {
-	const vid = req.params["vid"];
-	// TODO: check data req.body.chall (
-	const error = ChallengeModel.checkChallenge(chall);
-	ChallengeModel.create(chall, (err,lastId) => {
-		res.json(err || {cid: lastId["rowid"]});
-	});
+router.get("/challenges", (req,res) => {
+  ChallengeModel.getByUser(req.query["uid"], (err,challenges) => {
+    res.json(err || {challenges:challenges});
+  });
 });
 
-//// index
-//router.get("/challenges", access.logged, access.ajax, (req,res) => {
-//	if (req.query["uid"] != req.user._id)
-//		return res.json({errmsg: "Not your challenges"});
-//	let uid = ObjectID(req.query["uid"]);
-//	ChallengeModel.getByPlayer(uid, (err, challengeArray) => {
-//		res.json(err || {challenges: challengeArray});
-//	});
-//});
-//
-//function createChallenge(vid, from, to, res)
-//{
-//	ChallengeModel.create(vid, from, to, (err, chall) => {
-//		res.json(err || {
-//			// A challenge can be sent using only name, thus 'to' is returned
-//			to: chall.to,
-//			cid: chall._id
-//		});
-//	});
-//}
-//
-//// from[, to][,nameTo]
-//router.post("/challenges", access.logged, access.ajax, (req,res) => {
-//	if (req.body.from != req.user._id)
-//		return res.json({errmsg: "Identity usurpation"});
-//	let from = ObjectID(req.body.from);
-//	let to = !!req.body.to ? ObjectID(req.body.to) : undefined;
-//	let nameTo = !!req.body.nameTo ? req.body.nameTo : undefined;
-//	let vid = ObjectID(req.body.vid);
-//	if (!to && !!nameTo)
-//	{
-//		UserModel.getByName(nameTo, (err,user) => {
-//			access.checkRequest(res, err, user, "Opponent not found", () => {
-//				createChallenge(vid, from, user._id, res);
-//			});
-//		});
-//	}
-//	else if (!!to)
-//		createChallenge(vid, from, to, res);
-//	else
-//		createChallenge(vid, from, undefined, res); //automatch
-//});
-//
-//router.delete("/challenges", access.logged, access.ajax, (req,res) => {
-//	let cid = ObjectID(req.query.cid);
-//	ChallengeModel.getById(cid, (err,chall) => {
-//		access.checkRequest(res, err, chall, "Challenge not found", () => {
-//			if (!chall.from.equals(req.user._id) && !!chall.to && !chall.to.equals(req.user._id))
-//				return res.json({errmsg: "Not your challenge"});
-//			ChallengeModel.remove(cid, err => {
-//				res.json(err || {});
-//			});
-//		});
-//	});
-//});
+router.post("/challenges", access.logged, access.ajax, (req,res) => {
+  const error = ChallengeModel.checkChallenge(req.body.chall);
+  if (!!error)
+    return res.json({errmsg:error});
+  let challenge =
+  {
+    fen: req.body.chall.fen,
+    timeControl: req.body.chall.timeControl,
+    vid: req.body.chall.vid,
+    uid: req.userId,
+    to: req.body.chall.to, //string: user name (may be empty)
+  };
+  const insertChallenge = () => {
+    ChallengeModel.create(challenge, (err,ret) => {
+      return res.json(err || {cid:ret.cid});
+    });
+  };
+  if (!!req.body.chall.to)
+  {
+    UserModel.getOne("name", challenge.to, (err,user) => {
+      if (!!err || !user)
+        return res.json(err | {errmsg: "Typo in player name"});
+      challenge.to = user.id; //ready now to insert challenge
+      insertChallenge();
+      if (user.notify)
+        UserModel.notify(user, "New challenge: " + params.siteURL + "/");
+    });
+  }
+  else
+    insertChallenge();
+});
+
+router.delete("/challenges", access.logged, access.ajax, (req,res) => {
+  const cid = req.query.id;
+  ChallengeModel.safeRemove(cid, req.userId, err => {
+    res.json(err || {}); //TODO: just "return err" because is empty if no errors
+  });
+});
 
 module.exports = router;