X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=server%2Fmodels%2FGame.js;h=caa15c39579c992c1e474cfa294147726a6edd24;hb=584f81b93154313a3856112400b7df98e0eb2632;hp=27f5d1e3aede14f16f1f610161ccb8bd8d3ead9e;hpb=89021f181ac0689bbc785ce0ebd9a910e66352b0;p=vchess.git

diff --git a/server/models/Game.js b/server/models/Game.js
index 27f5d1e3..caa15c39 100644
--- a/server/models/Game.js
+++ b/server/models/Game.js
@@ -1,4 +1,4 @@
-var db = require("../utils/database");
+const db = require("../utils/database");
 const UserModel = require("./User");
 
 /*
@@ -34,17 +34,13 @@ const UserModel = require("./User");
 const GameModel =
 {
   checkGameInfo: function(g) {
-    if (!g.vid.toString().match(/^[0-9]+$/))
-      return "Wrong variant ID";
-    if (!g.cadence.match(/^[0-9dhms +]+$/))
-      return "Wrong characters in time control";
-    if (!g.fen.match(/^[a-zA-Z0-9, /-]*$/))
-      return "Bad FEN string";
-    if (g.players.length != 2)
-      return "Need exactly 2 players";
-    if (g.players.some(p => !p.id.toString().match(/^[0-9]+$/)))
-      return "Wrong characters in player ID";
-    return "";
+    return (
+      g.vid.toString().match(/^[0-9]+$/) &&
+      g.cadence.match(/^[0-9dhms +]+$/) &&
+      g.fen.match(/^[a-zA-Z0-9, /-]*$/) &&
+      g.players.length == 2 &&
+      g.players.every(p => p.uid.toString().match(/^[0-9]+$/))
+    );
   },
 
   create: function(vid, fen, cadence, players, cb)
@@ -52,72 +48,59 @@ const GameModel =
     db.serialize(function() {
       let query =
         "INSERT INTO Games " +
-        "(vid, fenStart, fen, score, cadence, created, drawOffer) " +
+        "(vid, fenStart, fen, cadence, created) " +
         "VALUES " +
-        "(" + vid + ",'" + fen + "','" + fen + "','*','" + cadence + "'," + Date.now() + ",'')";
+        "(" + vid + ",'" + fen + "','" + fen + "','" + cadence + "'," + Date.now() + ")";
       db.run(query, function(err) {
-        if (!!err)
-          return cb(err);
-        players.forEach((p,idx) => {
-          const color = (idx==0 ? "w" : "b");
-          query =
-            "INSERT INTO Players VALUES " +
-            "(" + this.lastID + "," + p.id + ",'" + color + "')";
-          db.run(query);
-        });
-        cb(null, {gid: this.lastID});
+        if (err)
+          cb(err)
+        else
+        {
+          players.forEach((p,idx) => {
+            const color = (idx==0 ? "w" : "b");
+            query =
+              "INSERT INTO Players VALUES " +
+              "(" + this.lastID + "," + p.uid + ",'" + color + "')";
+            db.run(query);
+          });
+          cb(null, {gid: this.lastID});
+        }
       });
     });
   },
 
   // TODO: some queries here could be async
-  getOne: function(id, light, cb)
+  getOne: function(id, cb)
   {
+    // NOTE: ignoring errors (shouldn't happen at this stage)
     db.serialize(function() {
       let query =
-        // NOTE: g.scoreMsg can be NULL
-        // (in this case score = "*" and no reason to look at it)
-        "SELECT g.id, g.vid, g.fen, g.fenStart, g.cadence, g.score, " +
-          "g.scoreMsg, g.drawOffer, v.name AS vname " +
+        "SELECT g.id, g.vid, g.fen, g.fenStart, g.cadence, g.created, g.score, " +
+          "g.scoreMsg, g.drawOffer, g.rematchOffer, v.name AS vname " +
         "FROM Games g " +
         "JOIN Variants v " +
         "  ON g.vid = v.id " +
         "WHERE g.id = " + id;
-      db.get(query, (err,gameInfo) => {
-        if (!!err)
-          return cb(err);
+      db.get(query, (err, gameInfo) => {
         query =
           "SELECT p.uid, p.color, u.name " +
           "FROM Players p " +
           "JOIN Users u " +
           "  ON p.uid = u.id " +
           "WHERE p.gid = " + id;
-        db.all(query, (err2,players) => {
-          if (!!err2)
-            return cb(err2);
-          if (light)
-          {
-            const game = Object.assign({},
-              gameInfo,
-              {players: players}
-            );
-            return cb(null, game);
-          }
+        db.all(query, (err2, players) => {
           query =
             "SELECT squares, played, idx " +
             "FROM Moves " +
             "WHERE gid = " + id;
-          db.all(query, (err3,moves) => {
-            if (!!err3)
-              return cb(err3);
+          db.all(query, (err3, moves) => {
             query =
               "SELECT msg, name, added " +
               "FROM Chats " +
               "WHERE gid = " + id;
-            db.all(query, (err4,chats) => {
-              if (!!err4)
-                return cb(err4);
-              const game = Object.assign({},
+            db.all(query, (err4, chats) => {
+              const game = Object.assign(
+                {},
                 gameInfo,
                 {
                   players: players,
@@ -125,7 +108,7 @@ const GameModel =
                   chats: chats,
                 }
               );
-              return cb(null, game);
+              cb(null, game);
             });
           });
         });
@@ -136,27 +119,72 @@ const GameModel =
   // For display on MyGames or Hall: no need for moves or chats
   getByUser: function(uid, excluded, cb)
   {
+    // Some fields are not required when showing a games list:
+    const getOneLight = (id, cb2) => {
+      let query =
+        "SELECT g.id, g.vid, g.fen, g.cadence, g.created, g.score, " +
+          "g.scoreMsg, g.deletedByWhite, g.deletedByBlack, v.name AS vname " +
+        "FROM Games g " +
+        "JOIN Variants v " +
+        "  ON g.vid = v.id " +
+        "WHERE g.id = " + id;
+      db.get(query, (err, gameInfo) => {
+        query =
+          "SELECT p.uid, p.color, u.name " +
+          "FROM Players p " +
+          "JOIN Users u " +
+          "  ON p.uid = u.id " +
+          "WHERE p.gid = " + id;
+        db.all(query, (err2, players) => {
+          query =
+            "SELECT COUNT(*) AS nbMoves " +
+            "FROM Moves " +
+            "WHERE gid = " + id;
+          db.get(query, (err,ret) => {
+            const game = Object.assign(
+              {},
+              gameInfo,
+              {
+                players: players,
+                movesCount: ret.nbMoves
+              }
+            );
+            cb2(game);
+          });
+        });
+      });
+    };
     db.serialize(function() {
-      const query =
-        "SELECT DISTINCT gid " +
-        "FROM Players " +
-        "WHERE uid " + (excluded ? "<>" : "=") + " " + uid;
+      let query = "";
+      if (uid == 0) {
+        // Special case anonymous user: show all games
+        query =
+          "SELECT id AS gid " +
+          "FROM Games";
+      }
+      else {
+        // Registered user:
+        query =
+          "SELECT gid " +
+          "FROM Players " +
+          "GROUP BY gid " +
+          "HAVING COUNT(uid = " + uid + " OR NULL) " +
+          (excluded ? " = 0" : " > 0");
+      }
       db.all(query, (err,gameIds) => {
-        if (!!err)
-          return cb(err);
-        if (gameIds.length == 0)
-          return cb(null, []);
-        let gameArray = [];
-        for (let i=0; i<gameIds.length; i++)
-        {
-          GameModel.getOne(gameIds[i]["gid"], true, (err2,game) => {
-            if (!!err2)
-              return cb(err2);
-            gameArray.push(game);
-            // Call callback function only when gameArray is complete:
-            if (i == gameIds.length - 1)
-              return cb(null, gameArray);
-          });
+        if (err || gameIds.length == 0) cb(err, []);
+        else {
+          let gameArray = [];
+          let gCounter = 0;
+          for (let i=0; i<gameIds.length; i++) {
+            getOneLight(gameIds[i]["gid"], (game) => {
+              gameArray.push(game);
+              gCounter++; //TODO: let's hope this is atomic?!
+              // Call callback function only when gameArray is complete:
+              if (gCounter == gameIds.length)
+                cb(null, gameArray);
+            });
+          }
         }
       });
     });
@@ -166,7 +194,7 @@ const GameModel =
   {
     db.serialize(function() {
       const query =
-        "SELECT id " +
+        "SELECT uid " +
         "FROM Players " +
         "WHERE gid = " + id;
       db.all(query, (err,players) => {
@@ -178,64 +206,87 @@ const GameModel =
   checkGameUpdate: function(obj)
   {
     // Check all that is possible (required) in obj:
-    if (!!obj.move)
-    {
-      if (!obj.move.played.toString().match(/^[0-9]+$/))
-        return "Wrong move played time";
-      if (!obj.move.idx.toString().match(/^[0-9]+$/))
-        return "Wrong move index";
-    }
-    if (!!obj.drawOffer && !obj.drawOffer.match(/^[wbtn]$/))
-      return "Wrong draw offer format";
-    if (!!obj.fen && !obj.fen.match(/^[a-zA-Z0-9, /-]*$/))
-      return "Wrong FEN string";
-    if (!!obj.score && !obj.score.match(/^[012?*\/-]+$/))
-      return "Wrong characters in score";
-    if (!!obj.scoreMsg && !obj.scoreMsg.match(/^[a-zA-Z ]+$/))
-      return "Wrong characters in score message";
-    if (!!obj.chat)
-      return UserModel.checkNameEmail({name: obj.chat.name});
-    return "";
+    return (
+      (
+        !obj.move || (
+          !!(obj.move.played.toString().match(/^[0-9]+$/)) &&
+          !!(obj.move.idx.toString().match(/^[0-9]+$/))
+        )
+      ) && (
+        !obj.drawOffer || !!(obj.drawOffer.match(/^[wbtn]$/))
+      ) && (
+        !obj.rematchOffer || !!(obj.rematchOffer.match(/^[wbn]$/))
+      ) && (
+        !obj.fen || !!(obj.fen.match(/^[a-zA-Z0-9, /-]*$/))
+      ) && (
+        !obj.score || !!(obj.score.match(/^[012?*\/-]+$/))
+      ) && (
+        !obj.scoreMsg || !!(obj.scoreMsg.match(/^[a-zA-Z ]+$/))
+      ) && (
+        !obj.chat || UserModel.checkNameEmail({name: obj.chat.name})
+      )
+    );
   },
 
-  // obj can have fields move, chat, fen, drawOffer and/or score
-  update: function(id, obj)
+  // obj can have fields move, chat, fen, drawOffer and/or score + message
+  update: function(id, obj, cb)
   {
     db.parallelize(function() {
       let query =
         "UPDATE Games " +
         "SET ";
       let modifs = "";
-      if (!!obj.message)
-        modifs += "message = message || ' ' || '" + obj.message + "',";
       // NOTE: if drawOffer is set, we should check that it's player's turn
       // A bit overcomplicated. Let's trust the client on that for now...
       if (!!obj.drawOffer)
       {
-        if (obj.drawOffer == "n") //Special "None" update
+        if (obj.drawOffer == "n") //special "None" update
           obj.drawOffer = "";
         modifs += "drawOffer = '" + obj.drawOffer + "',";
       }
+      if (!!obj.rematchOffer)
+      {
+        if (obj.rematchOffer == "n") //special "None" update
+          obj.rematchOffer = "";
+        modifs += "rematchOffer = '" + obj.rematchOffer + "',";
+      }
       if (!!obj.fen)
         modifs += "fen = '" + obj.fen + "',";
       if (!!obj.score)
         modifs += "score = '" + obj.score + "',";
       if (!!obj.scoreMsg)
         modifs += "scoreMsg = '" + obj.scoreMsg + "',";
+      if (!!obj.deletedBy) {
+        const myColor = obj.deletedBy == 'w' ? "White" : "Black";
+        modifs += "deletedBy" + myColor + " = true,";
+      }
       modifs = modifs.slice(0,-1); //remove last comma
       if (modifs.length > 0)
       {
         query += modifs + " WHERE id = " + id;
         db.run(query);
       }
+      // NOTE: move, chat and delchat are mutually exclusive
       if (!!obj.move)
       {
-        const m = obj.move;
+        // Security: only update moves if index is right
         query =
-          "INSERT INTO Moves (gid, squares, played, idx) VALUES " +
-          "(" + id + ",?," + m.played + "," + m.idx + ")";
-        db.run(query, JSON.stringify(m.squares));
+          "SELECT MAX(idx) AS maxIdx " +
+          "FROM Moves " +
+          "WHERE gid = " + id;
+        db.get(query, (err,ret) => {
+          const m = obj.move;
+          if (!ret.maxIdx || ret.maxIdx + 1 == m.idx) {
+            query =
+              "INSERT INTO Moves (gid, squares, played, idx) VALUES " +
+              "(" + id + ",?," + m.played + "," + m.idx + ")";
+            db.run(query, JSON.stringify(m.squares));
+            cb(null);
+          }
+          else cb({errmsg:"Wrong move index"});
+        });
       }
+      else cb(null);
       if (!!obj.chat)
       {
         query =
@@ -243,6 +294,29 @@ const GameModel =
             + id + ",?,'" + obj.chat.name + "'," + Date.now() + ")";
         db.run(query, obj.chat.msg);
       }
+      else if (obj.delchat)
+      {
+        query =
+          "DELETE " +
+          "FROM Chats " +
+          "WHERE gid = " + id;
+        db.run(query);
+      }
+      if (!!obj.deletedBy) {
+        // Did my opponent delete it too?
+        let selection =
+          "deletedBy" +
+          (obj.deletedBy == 'w' ? "Black" : "White") +
+          " AS deletedByOpp";
+        query =
+          "SELECT " + selection + " " +
+          "FROM Games " +
+          "WHERE id = " + id;
+        db.get(query, (err,ret) => {
+          // If yes: just remove game
+          if (!!ret.deletedByOpp) GameModel.remove(id);
+        });
+      }
     });
   },
 
@@ -275,7 +349,7 @@ const GameModel =
     const day = 86400000;
     db.serialize(function() {
       let query =
-        "SELECT id,created " +
+        "SELECT id, created " +
         "FROM Games ";
       db.all(query, (err,games) => {
         games.forEach(g => {