X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=server%2Fmodels%2FChallenge.js;h=dea0ac3908d1a3baaecaeb77cf2e6662585cb558;hb=0234201fb338fc239d6f613c677fa932c7c3697c;hp=e1fb448bc678c0cd498a5b67ed4a914b47e68017;hpb=98db2082fd31e7a7bc0348e31ce119f39dbc31b3;p=vchess.git

diff --git a/server/models/Challenge.js b/server/models/Challenge.js
index e1fb448b..dea0ac39 100644
--- a/server/models/Challenge.js
+++ b/server/models/Challenge.js
@@ -1,154 +1,82 @@
-var db = require("../utils/database");
+const db = require("../utils/database");
+const UserModel = require("./User");
 
 /*
- * Structure table Challenges:
+ * Structure:
  *   id: integer
  *   added: datetime
  *   uid: user id (int)
+ *   target: recipient id (optional)
  *   vid: variant id (int)
- *   nbPlayers: integer
+ *   randomness: integer in 0..2
  *   fen: varchar (optional)
- *   mainTime: integer
- *   addTime: integer
- *
- * Structure table WillPlay:
- *   cid: ref challenge id
- *   uid: ref user id
+ *   cadence: string (3m+2s, 7d ...)
  */
 
-const ChallengeModel =
-{
-	checkChallenge: function(c)
-	{
-		const vid = parseInt(c.vid);
-		if (isNaN(vid) || vid <= 0)
-			return "Please select a variant";
+const ChallengeModel = {
+  checkChallenge: function(c) {
+    return (
+      c.vid.toString().match(/^[0-9]+$/) &&
+      c.cadence.match(/^[0-9dhms +]+$/) &&
+      c.randomness.toString().match(/^[0-2]$/) &&
+      c.fen.match(/^[a-zA-Z0-9, /-]*$/) &&
+      (!c.to || UserModel.checkNameEmail({ name: c.to }))
+    );
+  },
 
-		const mainTime = parseInt(c.mainTime);
-		const increment = parseInt(c.increment);
-		if (isNaN(mainTime) || mainTime <= 0)
-			return "Main time should be strictly positive";
-		if (isNaN(increment) || increment < 0)
-			return "Increment must be positive";
+  create: function(c, cb) {
+    db.serialize(function() {
+      const query =
+        "INSERT INTO Challenges " +
+          "(added, uid, " + (c.to ? "target, " : "") +
+          "vid, randomness, fen, cadence) " +
+        "VALUES " +
+          "(" + Date.now() + "," + c.uid + "," + (c.to ? c.to + "," : "") +
+          c.vid + "," + c.randomness + ",'" + c.fen + "','" + c.cadence + "')";
+      db.run(query, function(err) {
+        cb(err, { id: this.lastID });
+      });
+    });
+  },
 
-		// Basic alphanumeric check for players names
-		let playerCount = 0;
-		for (p of c.players)
-		{
-			if (p.name.length > 0)
-			{
-				if (!p.name.match(/^[\w]+$/))
-					return "Wrong characters in players names";
-				playerCount++;
-			}
-		}
+  // All challenges related to user with ID uid
+  getByUser: function(uid, cb) {
+    db.serialize(function() {
+      const query =
+        "SELECT * " +
+        "FROM Challenges " +
+        "WHERE target IS NULL" +
+          " OR uid = " + uid +
+          " OR target = " + uid;
+      db.all(query, (err, challenges) => {
+        cb(err, challenges);
+      });
+    });
+  },
 
-		if (playerCount > 0 && playerCount != c.nbPlayers-1)
-			return "None, or all of the opponent names must be filled"
+  remove: function(id) {
+    db.serialize(function() {
+      const query =
+        "DELETE FROM Challenges " +
+        "WHERE id = " + id;
+      db.run(query);
+    });
+  },
 
-		// Just characters check on server:
-		if (!c.fen.match(/^[a-zA-Z0-9, /-]*$/))
-			return "Bad FEN string";
-	},
-
-	// fen cannot be undefined; TODO: generate fen on server instead
-	create: function(c, cb)
-	{
-		db.serialize(function() {
-			let query =
-				"INSERT INTO Challenges " +
-				"(added, uid, vid, nbPlayers, fen, mainTime, addTime) VALUES " +
-				"(" + Date.now() + "," + c.uid + "," + c.vid + "," + c.nbPlayers +
-					",'" + c.fen + "'," + c.mainTime + "," + c.increment + ")";
-			db.run(query, err => {
-				if (!!err)
-					return cb(err);
-				db.get("SELECT last_insert_rowid() AS rowid", (err2,lastId) => {
-					query =
-						"INSERT INTO WillPlay VALUES " +
-						"(" + lastId["rowid"] + "," + c.uid + ")";
-						db.run(query, (err,ret) => {
-							cb(err, lastId); //all we need is the challenge ID
-						});
-				});
-			});
-		});
-	},
-
-	getOne: function(id, cb)
-	{
-		db.serialize(function() {
-			let query =
-				"SELECT * " +
-				"FROM Challenges c " +
-				"JOIN Variants v " +
-				"  ON c.vid = v.id "
-				"WHERE id = " + id;
-			db.get(query, (err,challengeInfo) => {
-				if (!!err)
-					return cb(err);
-				query =
-					"SELECT w.uid AS id, u.name " +
-					"FROM WillPlay w " +
-					"JOIN Users u " +
-					"  ON w.uid = u.id " +
-					"WHERE w.cid = " + id;
-				db.run(query, (err2,players) => {
-					if (!!err2)
-						return cb(err2);
-					const challenge = {
-						id: id,
-						uid: challengeInfo.uid,
-						vname: challengeInfo.name,
-						added: challengeInfo.added,
-						nbPlayers: challengeInfo.nbPlayers,
-						players: players, //currently in
-						fen: challengeInfo.fen,
-						mainTime: challengeInfo.mainTime,
-						increment: challengeInfo.addTime,
-					};
-					return cb(null, challenge);
-				});
-			});
-		});
-	},
-
-	getByUser: function(uid, cb)
-	{
-		db.serialize(function() {
-			const query =
-				"SELECT cid " +
-				"FROM WillPlay " +
-				"WHERE uid = " + uid;
-			db.run(query, (err,challIds) => {
-				if (!!err)
-					return cb(err);
-				let challenges = [];
-				challIds.forEach(cidRow => {
-					ChallengeModel.getOne(cidRow["cid"], (err2,chall) => {
-						if (!!err2)
-							return cb(err2);
-						challenges.push(chall);
-					});
-				});
-				return cb(null, challenges);
-			});
-		});
-	},
-
-	remove: function(id)
-	{
-		db.parallelize(function() {
-			let query =
-				"DELETE FROM Challenges " +
-				"WHERE id = " + id;
-			db.run(query);
-			query =
-				"DELETE FROM WillPlay " +
-				"WHERE cid = " + id;
-			db.run(query);
-		});
-	},
+  safeRemove: function(id, uid) {
+    db.serialize(function() {
+      const query =
+        "SELECT 1 " +
+        "FROM Challenges " +
+        "WHERE id = " + id + " " +
+          // Condition: I'm the sender or the target
+          "AND (uid = " + uid + " OR target = " + uid + ")";
+      db.get(query, (err,chall) => {
+        if (!err && chall)
+          ChallengeModel.remove(id);
+      });
+    });
+  },
 }
 
 module.exports = ChallengeModel;