X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=models%2FUser.js;h=6eff2735684af0271e0b753a94a1b278c9883589;hb=ff1d4c3f43d8333e9629a8e59606c234cb10869f;hp=66b1bf549b738d0acf6be27e1c4ee2244901b17e;hpb=8d7e2786f5a67a1b9a77c742d7951e0efbe8747d;p=vchess.git

diff --git a/models/User.js b/models/User.js
index 66b1bf54..6eff2735 100644
--- a/models/User.js
+++ b/models/User.js
@@ -1,5 +1,7 @@
 var db = require("../utils/database");
 var maild = require("../utils/mailer.js");
+var TokenGen = require("../utils/tokenGenerator");
+var params = require("../config/parameters");
 
 /*
  * Structure:
@@ -15,13 +17,16 @@ var maild = require("../utils/mailer.js");
 // User creation
 exports.create = function(name, email, notify, callback)
 {
-	if (!notify)
-		notify = false; //default
 	db.serialize(function() {
-		db.run(
+		const insertQuery =
 			"INSERT INTO Users " +
 			"(name, email, notify) VALUES " +
-			"(" + name + "," + email + "," + notify + ")");
+			"('" + name + "', '" + email + "', " + notify + ")";
+		db.run(insertQuery, err => {
+			if (!!err)
+				return callback(err);
+			db.get("SELECT last_insert_rowid() AS rowid", callback);
+		});
 	});
 }
 
@@ -30,10 +35,11 @@ exports.getOne = function(by, value, cb)
 {
 	const delimiter = (typeof value === "string" ? "'" : "");
 	db.serialize(function() {
-		db.get(
-			"SELECT * FROM Users " +
-			"WHERE " + by " = " + delimiter + value + delimiter,
-			callback);
+		const query =
+			"SELECT * " +
+			"FROM Users " +
+			"WHERE " + by + " = " + delimiter + value + delimiter;
+		db.get(query, cb);
 	});
 }
 
@@ -43,32 +49,48 @@ exports.getOne = function(by, value, cb)
 exports.setLoginToken = function(token, uid, cb)
 {
 	db.serialize(function() {
-		db.run(
+		const query =
 			"UPDATE Users " +
-			"SET loginToken = " + token + " AND loginTime = " + Date.now() + " " +
-			"WHERE id = " + uid);
+			"SET loginToken = '" + token + "', loginTime = " + Date.now() + " " +
+			"WHERE id = " + uid;
+		db.run(query, cb);
 	});
 }
 
-exports.setSessionToken = function(token, uid, cb)
+// Set session token only if empty (first login)
+// TODO: weaker security (but avoid to re-login everywhere after each logout)
+exports.trySetSessionToken = function(uid, cb)
 {
 	// Also empty the login token to invalidate future attempts
 	db.serialize(function() {
-		db.run(
-			"UPDATE Users " +
-			"SET loginToken = NULL AND sessionToken = " + token + " " +
-			"WHERE id = " + uid);
+		const querySessionToken =
+			"SELECT sessionToken " +
+			"FROM Users " +
+			"WHERE id = " + uid;
+		db.get(querySessionToken, (err,ret) => {
+			if (!!err)
+				return cb(err);
+			const token = ret.sessionToken || TokenGen.generate(params.token.length);
+			const queryUpdate =
+				"UPDATE Users " +
+				"SET loginToken = NULL" +
+				(!ret.sessionToken ? (", sessionToken = '" + token + "'") : "") + " " +
+				"WHERE id = " + uid;
+			db.run(queryUpdate);
+			cb(null, token);
+		});
 	});
 }
 
-exports.updateSettings = function(name, email, notify, cb)
+exports.updateSettings = function(user, cb)
 {
 	db.serialize(function() {
-		db.run(
+		const query =
 			"UPDATE Users " +
-			"SET name = " + name +
-			" AND email = " + email +
-			" AND notify = " + notify + " " +
-			"WHERE id = " + uid);
+			"SET name = '" + user.name + "'" +
+			", email = '" + user.email + "'" +
+			", notify = " + user.notify + " " +
+			"WHERE id = " + user.id;
+		db.run(query, cb);
 	});
 }