X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=client%2Fsrc%2Fviews%2FHall.vue;h=f9519fe2681d69493f80034f0436477d591876a7;hb=585d095517ca2aedab8ad125cc7c39b90e13d5cc;hp=5217c34de312a0b4bc4eddc3f05c6b494fab2a2d;hpb=cafe016679ee9c14bf7bf0a37104ade7f74aff89;p=vchess.git diff --git a/client/src/views/Hall.vue b/client/src/views/Hall.vue index 5217c34d..f9519fe2 100644 --- a/client/src/views/Hall.vue +++ b/client/src/views/Hall.vue @@ -34,7 +34,7 @@ main ) .card label#closeNewgame.modal-close(for="modalNewgame") - div(@keyup.enter="newChallenge()") + div(@keyup.enter="issueNewChallenge()") fieldset label(for="selectVariant") {{ st.tr["Variant"] }} * select#selectVariant( @@ -65,8 +65,21 @@ main option(value="0") {{ st.tr["Deterministic"] }} option(value="1") {{ st.tr["Symmetric random"] }} option(value="2") {{ st.tr["Asymmetric random"] }} + fieldset + label(for="memorizeChall") {{ st.tr["Memorize"] }} + input#memorizeChall( + type="checkbox" + v-model="newchallenge.memorize" + ) fieldset(v-if="st.user.id > 0") - label(for="selectPlayers") {{ st.tr["Play with?"] }} + label(for="selectPlayers") {{ st.tr["Play with"] }} + select#selectPlayersInList(v-model="newchallenge.to") + option(value="") + option( + v-for="p in Object.values(people)" + :value="p.name" + ) + | {{ p.name }} input#selectPlayers( type="text" v-model="newchallenge.to" @@ -79,7 +92,7 @@ main v-model="newchallenge.fen" ) .diagram(v-html="newchallenge.diag") - button(@click="newChallenge()") {{ st.tr["Send challenge"] }} + button(@click="issueNewChallenge()") {{ st.tr["Send challenge"] }} input#modalPeople.modal( type="checkbox" @click="resetSocialColor()" @@ -122,6 +135,26 @@ main | {{ st.tr["Who's there?"] }} button(@click="showNewchallengeForm()") | {{ st.tr["New game"] }} + .row(v-if="presetChalls.length > 0") + .col-sm-12.col-md-10.col-md-offset-1.col-lg-8.col-lg-offset-2 + h4.text-center {{ st.tr["Preset challenges"] }} + table + thead + tr + th {{ st.tr["Variant"] }} + th {{ st.tr["Cadence"] }} + th {{ st.tr["Random?"] }} + th + tbody + tr( + v-for="pc in presetChalls" + @click="newChallFromPreset(pc)" + ) + td {{ pc.vname }} + td {{ pc.cadence }} + td(:class="getRandomnessClass(pc)") + td.remove-preset(@click="removePresetChall($event, pc)") + img(src="/images/icons/delete.svg") .row .col-sm-12.col-md-10.col-md-offset-1.col-lg-8.col-lg-offset-2 div#div2 @@ -194,15 +227,17 @@ export default { vid: parseInt(localStorage.getItem("vid")) || 0, to: "", //name of challenged player (if any) cadence: localStorage.getItem("cadence") || "", - randomness: parseInt(localStorage.getItem("randomness")) || 2, + randomness: parseInt(localStorage.getItem("challRandomness")) || 2, // VariantRules object, stored to not interfere with // diagrams of targetted challenges: V: null, vname: "", - diag: "" //visualizing FEN + diag: "", //visualizing FEN + memorize: false //put settings in localStorage }, tchallDiag: "", curChallToAccept: {from: {}}, + presetChalls: JSON.parse(localStorage.getItem("presetChalls") || "[]"), newChat: "", conn: null, connexionString: "", @@ -245,6 +280,45 @@ export default { pages: [{ path: "/", focus: true }] } ); + const connectAndPoll = () => { + this.send("connect"); + this.send("pollclientsandgamers"); + }; + // Initialize connection + this.connexionString = + params.socketUrl + + "/?sid=" + + this.st.user.sid + + "&id=" + + this.st.user.id + + "&tmpId=" + + getRandString() + + "&page=" + + // Hall: path is "/" (could be hard-coded as well) + encodeURIComponent(this.$route.path); + this.conn = new WebSocket(this.connexionString); + this.conn.onopen = connectAndPoll; + this.conn.onmessage = this.socketMessageListener; + this.conn.onclose = this.socketCloseListener; + }, + mounted: function() { + document.addEventListener('visibilitychange', this.visibilityChange); + ["peopleWrap", "infoDiv", "newgameDiv"].forEach(eltName => { + document.getElementById(eltName) + .addEventListener("click", processModalClick); + }); + document.querySelectorAll("#predefinedCadences > button").forEach(b => { + b.addEventListener("click", () => { + this.newchallenge.cadence = b.innerHTML; + }); + }); + const dispCorr = this.$route.query["disp"]; + const showCtype = + dispCorr || localStorage.getItem("type-challenges") || "live"; + const showGtype = + dispCorr || localStorage.getItem("type-games") || "live"; + this.setDisplay('c', showCtype); + this.setDisplay('g', showGtype); // Ask server for current corr games (all but mines) ajax( "/games", @@ -252,11 +326,27 @@ export default { { data: { uid: this.st.user.id, excluded: true }, success: (response) => { + if ( + response.games.length > 0 && + this.games.length == 0 && + this.gdisplay == "live" + ) { + document + .getElementById("btnGcorr") + .classList.add("somethingnew"); + } this.games = this.games.concat( response.games.map(g => { const type = this.classifyObject(g); const vname = this.getVname(g.vid); - return Object.assign({}, g, { type: type, vname: vname }); + return Object.assign( + {}, + g, + { + type: type, + vname: vname + } + ); }) ); } @@ -269,6 +359,15 @@ export default { { data: { uid: this.st.user.id }, success: (response) => { + if ( + response.challenges.length > 0 && + this.challenges.length == 0 && + this.cdisplay == "live" + ) { + document + .getElementById("btnCcorr") + .classList.add("somethingnew"); + } // Gather all senders names, and then retrieve full identity: // (TODO [perf]: some might be online...) let names = {}; @@ -315,51 +414,17 @@ export default { } } ); - const connectAndPoll = () => { - this.send("connect"); - this.send("pollclientsandgamers"); - }; - // Initialize connection - this.connexionString = - params.socketUrl + - "/?sid=" + - this.st.user.sid + - "&id=" + - this.st.user.id + - "&tmpId=" + - getRandString() + - "&page=" + - // Hall: path is "/" (could be hard-coded as well) - encodeURIComponent(this.$route.path); - this.conn = new WebSocket(this.connexionString); - this.conn.onopen = connectAndPoll; - this.conn.onmessage = this.socketMessageListener; - this.conn.onclose = this.socketCloseListener; - }, - mounted: function() { - document.addEventListener('visibilitychange', this.visibilityChange); - ["peopleWrap", "infoDiv", "newgameDiv"].forEach(eltName => { - let elt = document.getElementById(eltName); - elt.addEventListener("click", processModalClick); - }); - document.querySelectorAll("#predefinedCadences > button").forEach(b => { - b.addEventListener("click", () => { - this.newchallenge.cadence = b.innerHTML; - }); - }); - const dispCorr = this.$route.query["disp"]; - const showCtype = - dispCorr || localStorage.getItem("type-challenges") || "live"; - const showGtype = - dispCorr || localStorage.getItem("type-games") || "live"; - this.setDisplay("c", showCtype); - this.setDisplay("g", showGtype); }, beforeDestroy: function() { document.removeEventListener('visibilitychange', this.visibilityChange); this.send("disconnect"); }, methods: { + getRandomnessClass: function(pc) { + return { + ["random-" + pc.randomness]: true + }; + }, visibilityChange: function() { // TODO: Use document.hidden? https://webplatform.news/issues/2019-03-27 this.send( @@ -373,11 +438,37 @@ export default { this.newchallenge.to = ""; this.newchallenge.fen = ""; this.newchallenge.diag = ""; + this.newchallenge.memorize = false; }, showNewchallengeForm: function() { this.partialResetNewchallenge(); window.doClick("modalNewgame"); }, + addPresetChall: function(chall) { + // Add only if not already existing: + if (this.presetChalls.some(c => + c.vid == chall.vid && + c.cadence == chall.cadence && + c.randomness == chall.randomness + )) { + return; + } + const L = this.presetChalls.length; + this.presetChalls.push({ + index: L, + vid: chall.vid, + vname: chall.vname, //redundant, but easier + cadence: chall.cadence, + randomness: chall.randomness + }); + localStorage.setItem("presetChalls", JSON.stringify(this.presetChalls)); + }, + removePresetChall: function(e, pchall) { + e.stopPropagation(); + const pchallIdx = this.presetChalls.findIndex(pc => pc.index == pchall.index); + this.presetChalls.splice(pchallIdx, 1); + localStorage.setItem("presetChalls", JSON.stringify(this.presetChalls)); + }, tchallButtonsMargin: function() { if (!!this.curChallToAccept.fen) return { "margin-top": "10px" }; return {}; @@ -403,7 +494,7 @@ export default { return this.games.filter(g => g.type == type); }, classifyObject: function(o) { - //challenge or game + // o: challenge or game return o.cadence.indexOf("d") === -1 ? "live" : "corr"; }, setDisplay: function(letter, type, e) { @@ -437,6 +528,7 @@ export default { this.partialResetNewchallenge(); // Available, in Hall this.newchallenge.to = this.people[sid].name; + // TODO: also store target sid to not re-search for it document.getElementById("modalPeople").checked = false; window.doClick("modalNewgame"); }, @@ -501,7 +593,7 @@ export default { this.people[s.sid].pages.push({ path: page, focus: true }); if (!s.page) // Peer is in Hall - this.send("askchallenge", { target: s.sid }); + this.send("askchallenges", { target: s.sid }); // Peer is in Game else this.send("askgame", { target: s.sid, page: page }); }); @@ -510,11 +602,11 @@ export default { case "connect": case "gconnect": { const page = data.page || "/"; - // Only ask game / challenge if first connexion: + // Only ask game / challenges if first connexion: if (!this.people[data.from]) { this.people[data.from] = { pages: [{ path: page, focus: true }] }; if (data.code == "connect") - this.send("askchallenge", { target: data.from }); + this.send("askchallenges", { target: data.from }); else this.send("askgame", { target: data.from, page: page }); } else { // Append page if not already in list @@ -536,23 +628,23 @@ export default { if (!this.people[data.from]) return; // Disconnect means no more tmpIds: if (data.code == "disconnect") { - // Remove the live challenge sent by this player: + // Remove the live challenges sent by this player: ArrayFun.remove( this.challenges, - c => c.type == "live" && c.from.sid == data.from + c => c.type == "live" && c.from.sid == data.from, + "all" ); } else { // Remove the matching live game if now unreachable const gid = data.page.match(/[a-zA-Z0-9]+$/)[0]; - const gidx = this.games.findIndex(g => g.id == gid); - if (gidx >= 0) { - const game = this.games[gidx]; - if ( - game.type == "live" && - game.rids.length == 1 && - game.rids[0] == data.from - ) { - this.games.splice(gidx, 1); + // Corr games are always reachable: + if (!gid.match(/^[0-9]+$/)) { + const gidx = this.games.findIndex(g => g.id == gid); + // NOTE: gidx should always be >= 0 (TODO?) + if (gidx >= 0) { + const game = this.games[gidx]; + ArrayFun.remove(game.rids, rid => rid == data.from); + if (game.rids.length == 0) this.games.splice(gidx, 1); } } } @@ -583,7 +675,7 @@ export default { alert(this.st.tr["New connexion detected: tab now offline"]); break; case "askidentity": { - // Request for identification (TODO: anonymous shouldn't need to reply) + // Request for identification const me = { // Decompose to avoid revealing email name: this.st.user.name, @@ -617,77 +709,64 @@ export default { } break; } - case "askchallenge": { - // Send my current live challenge (if any) - const cIdx = this.challenges.findIndex( - c => c.from.sid == this.st.user.sid && c.type == "live" - ); - if (cIdx >= 0) { - const c = this.challenges[cIdx]; - // NOTE: in principle, should only send targeted challenge to the target. - // But we may not know yet the identity of the target (just name), - // so cannot decide if data.from is the target or not. - const myChallenge = { - id: c.id, - from: this.st.user.sid, - to: c.to, - randomness: c.randomness, - fen: c.fen, - vid: c.vid, - cadence: c.cadence, - added: c.added - }; - this.send("challenge", { data: myChallenge, target: data.from }); - } + case "askchallenges": { + // Send my current live challenges (if any) + const myChallenges = this.challenges + .filter(c => + c.from.sid == this.st.user.sid && c.type == "live" + ) + .map(c => { + // NOTE: in principle, should only send targeted challenge to the target. + // But we may not know yet the identity of the target (just name), + // so cannot decide if data.from is the target or not. + return { + id: c.id, + from: this.st.user.sid, + to: c.to, + randomness: c.randomness, + fen: c.fen, + vid: c.vid, + cadence: c.cadence, + added: c.added + }; + }); + if (myChallenges.length > 0) + this.send("challenges", { data: myChallenges, target: data.from }); break; } - case "challenge": //after "askchallenge" - case "newchallenge": { - // NOTE about next condition: see "askchallenge" case. - const chall = data.data; - if ( - !chall.to || - (this.people[chall.from].id > 0 && - (chall.from == this.st.user.sid || chall.to == this.st.user.name)) - ) { - let newChall = Object.assign({}, chall); - newChall.type = this.classifyObject(chall); - newChall.randomness = chall.randomness; - newChall.added = Date.now(); - let fromValues = Object.assign({}, this.people[chall.from]); - delete fromValues["pages"]; //irrelevant in this context - newChall.from = Object.assign({ sid: chall.from }, fromValues); - newChall.vname = this.getVname(newChall.vid); - this.challenges.push(newChall); - if ( - (newChall.type == "live" && this.cdisplay == "corr") || - (newChall.type == "corr" && this.cdisplay == "live") - ) { - document - .getElementById("btnC" + newChall.type) - .classList.add("somethingnew"); - } - } + case "challenges": //after "askchallenges" + data.data.forEach(this.addChallenge); + break; + case "newchallenge": + this.addChallenge(data.data); break; - } case "refusechallenge": { const cid = data.data; ArrayFun.remove(this.challenges, c => c.id == cid); alert(this.st.tr["Challenge declined"]); break; } - case "deletechallenge": { - // NOTE: the challenge may be already removed - const cid = data.data; - ArrayFun.remove(this.challenges, c => c.id == cid); + case "deletechallenge_s": { + // NOTE: the challenge(s) may be already removed + const cref = data.data; + if (!!cref.cid) ArrayFun.remove(this.challenges, c => c.id == cref.cid); + else if (!!cref.sids) { + cref.sids.forEach(s => { + ArrayFun.remove( + this.challenges, + c => c.type == "live" && c.from.sid == s, + "all" + ); + }); + } break; } - case "game": //individual request - case "newgame": { + case "game": { + // Individual request const game = data.data; // Ignore games where I play (will go in MyGames page) if (game.players.every(p => - p.sid != this.st.user.sid || p.uid != this.st.user.id)) + p.sid != this.st.user.sid && p.uid != this.st.user.id)) { let locGame = this.games.find(g => g.id == game.id); if (!locGame) { @@ -695,7 +774,7 @@ export default { newGame.type = this.classifyObject(game); newGame.vname = this.getVname(game.vid); if (!game.score) - //if new game from Hall + // New game from Hall newGame.score = "*"; newGame.rids = [game.rid]; delete newGame["rid"]; @@ -752,13 +831,38 @@ export default { this.conn.addEventListener("close", this.socketCloseListener); }, // Challenge lifecycle: + addChallenge: function(chall) { + // NOTE about next condition: see "askchallenges" case. + if ( + !chall.to || + (this.people[chall.from].id > 0 && + (chall.from == this.st.user.sid || chall.to == this.st.user.name)) + ) { + let newChall = Object.assign({}, chall); + newChall.type = this.classifyObject(chall); + newChall.randomness = chall.randomness; + newChall.added = Date.now(); + let fromValues = Object.assign({}, this.people[chall.from]); + delete fromValues["pages"]; //irrelevant in this context + newChall.from = Object.assign({ sid: chall.from }, fromValues); + newChall.vname = this.getVname(newChall.vid); + this.challenges.push(newChall); + if ( + (newChall.type == "live" && this.cdisplay == "corr") || + (newChall.type == "corr" && this.cdisplay == "live") + ) { + document + .getElementById("btnC" + newChall.type) + .classList.add("somethingnew"); + } + } + }, loadNewchallVariant: async function(cb) { const vname = this.getVname(this.newchallenge.vid); const vModule = await import("@/variants/" + vname + ".js"); this.newchallenge.V = vModule.VariantRules; this.newchallenge.vname = vname; - if (!!cb) - cb(); + if (!!cb) cb(); }, trySetNewchallDiag: function() { if (!this.newchallenge.fen) { @@ -779,7 +883,14 @@ export default { }); } }, - newChallenge: async function() { + newChallFromPreset(pchall) { + this.partialResetNewchallenge(); + this.newchallenge.vid = pchall.vid; + this.newchallenge.cadence = pchall.cadence; + this.newchallenge.randomness = pchall.randomness; + this.loadNewchallVariant(this.issueNewChallenge); + }, + issueNewChallenge: async function() { if (!!(this.newchallenge.cadence.match(/^[0-9]+$/))) this.newchallenge.cadence += "+0"; //assume minutes, no increment const ctype = this.classifyObject(this.newchallenge); @@ -795,8 +906,9 @@ export default { else if ( ctype == "live" && Object.values(this.people).every(p => p.name != this.newchallenge.to) - ) + ) { error = this.newchallenge.to + " " + this.st.tr["is not online"]; + } } if (error) { alert(error); @@ -810,27 +922,52 @@ export default { } // NOTE: "from" information is not required here let chall = Object.assign({}, this.newchallenge); + // Add only if not already issued (not counting target or FEN): + if (this.challenges.some(c => + (c.from.sid == this.st.user.sid || c.from.id == this.st.user.id) && + c.vid == chall.vid && + c.cadence == chall.cadence && + c.randomness == chall.randomness + )) { + alert(this.st.tr["Challenge already exists"]); + return; + } + if (this.newchallenge.memorize) this.addPresetChall(this.newchallenge); delete chall["V"]; delete chall["diag"]; const finishAddChallenge = cid => { chall.id = cid || "c" + getRandString(); - // Remove old challenge if any (only one at a time of a given type): - const cIdx = this.challenges.findIndex( - c => - (c.from.sid == this.st.user.sid || c.from.id == this.st.user.id) && - c.type == ctype - ); - if (cIdx >= 0) { - // Delete current challenge (will be replaced now) - this.send("deletechallenge", { data: this.challenges[cIdx].id }); + const MAX_ALLOWED_CHALLS = 3; + // Remove oldest challenge if 3 found: only 3 at a time of a given type + let countMyChalls = 0; + let challToDelIdx = 0; + let oldestAdded = Number.MAX_SAFE_INTEGER; + for (let i=0; i= MAX_ALLOWED_CHALLS) { + this.send( + "deletechallenge_s", + { data: { cid: this.challenges[challToDelIdx].id } } + ); if (ctype == "corr") { ajax( "/challenges", "DELETE", - { data: { id: this.challenges[cIdx].id } } + { data: { id: this.challenges[challToDelIdx].id } } ); } - this.challenges.splice(cIdx, 1); + this.challenges.splice(challToDelIdx, 1); } this.send("newchallenge", { data: Object.assign({ from: this.st.user.sid }, chall) @@ -850,7 +987,7 @@ export default { // Remember cadence + vid for quicker further challenges: localStorage.setItem("cadence", chall.cadence); localStorage.setItem("vid", chall.vid); - localStorage.setItem("randomness", chall.randomness); + localStorage.setItem("challRandomness", chall.randomness); document.getElementById("modalNewgame").checked = false; // Show the challenge if not on current display if ( @@ -893,6 +1030,12 @@ export default { name: this.st.user.name }; this.launchGame(c); + if (c.type == "live") + // Remove all live challenges of both players + this.send("deletechallenge_s", { data: { sids: [c.from.sid, c.seat.sid] } }); + else + // Corr challenge: just remove the challenge + this.send("deletechallenge_s", { data: { cid: c.id } }); } else { const oppsid = this.getOppsid(c); if (!!oppsid) @@ -904,9 +1047,10 @@ export default { { data: { id: c.id } } ); } + this.send("deletechallenge_s", { data: { cid: c.id } }); } - this.send("deletechallenge", { data: c.id }); }, + // TODO: if several players click same challenge at the same time: problem clickChallenge: async function(c) { const myChallenge = c.from.sid == this.st.user.sid || //live @@ -943,7 +1087,7 @@ export default { { data: { id: c.id } } ); } - this.send("deletechallenge", { data: c.id }); + this.send("deletechallenge_s", { data: { cid: c.id } }); } // In all cases, the challenge is consumed: ArrayFun.remove(this.challenges, ch => ch.id == c.id); @@ -976,10 +1120,7 @@ export default { if (!!oppsid) // Opponent is online this.send("startgame", { data: gameInfo, target: oppsid }); - // Send game info (only if live) to everyone except me and opponent - // TODO: this double message send could be avoided. - this.send("newgame", { data: gameInfo, oppsid: oppsid }); - // Also to MyGames page: + // Notify MyGames page: this.send( "notifynewgame", { @@ -989,6 +1130,8 @@ export default { }) } ); + // NOTE: no need to send the game to the room, since I'll connect + // on game just after, the main Hall will be notified. }; if (c.type == "live") { notifyNewgame(); @@ -1136,4 +1279,22 @@ button.refuseBtn @media screen and (max-width: 767px) #div2, #div3 margin-top: 0 + +tr > td + &.random-0 + background-color: #FF5733 + &.random-1 + background-color: #2B63B4 + &.random-2 + background-color: #33B42B + +@media screen and (max-width: 767px) + h4 + margin: 5px 0 + +td.remove-preset + background-color: lightgrey + text-align: center + & > img + height: 1em