X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=client%2Fsrc%2Fviews%2FHall.vue;h=db8f528b00f069f844b125e83a75715c849dc984;hb=120fe373ca3b9e83e33bd59979af10fe09350fc5;hp=7697e1b534a15d1b27f75afea131b9b7ab62ef9f;hpb=5ea8d11307ef9e50bdd0b93708570976f3f6012e;p=vchess.git

diff --git a/client/src/views/Hall.vue b/client/src/views/Hall.vue
index 7697e1b5..db8f528b 100644
--- a/client/src/views/Hall.vue
+++ b/client/src/views/Hall.vue
@@ -1,66 +1,72 @@
 <template lang="pug">
 main
   input#modalInfo.modal(type="checkbox")
-  div(role="dialog" aria-labelledby="infoMessage")
+  div#infoDiv(role="dialog" data-checkbox="modalInfo" aria-labelledby="infoMessage")
     .card.smallpad.small-modal.text-center
       label.modal-close(for="modalInfo")
       h3#infoMessage.section
         p(v-html="infoMessage")
   input#modalNewgame.modal(type="checkbox")
-  div(role="dialog" data-checkbox="modalNewgame"
+  div#newgameDiv(role="dialog" data-checkbox="modalNewgame"
       aria-labelledby="titleFenedit")
     .card.smallpad(@keyup.enter="newChallenge")
       label#closeNewgame.modal-close(for="modalNewgame")
       fieldset
-        label(for="selectVariant") {{ st.tr["Variant"] }}
+        label(for="selectVariant") {{ st.tr["Variant"] }} *
         select#selectVariant(v-model="newchallenge.vid")
-          option(v-for="v in st.variants" :value="v.id") {{ v.name }}
+          option(v-for="v in st.variants" :value="v.id"
+              :selected="newchallenge.vid==v.id")
+            | {{ v.name }}
       fieldset
-        label(for="timeControl") {{ st.tr["Time control"] }}
+        label(for="timeControl") {{ st.tr["Time control"] }} *
+        div#predefinedTimeControls
+          button 3+2
+          button 5+3
+          button 15+5
         input#timeControl(type="text" v-model="newchallenge.timeControl"
-          placeholder="3m+2s, 1h+30s, 7d+1d ...")
+          placeholder="5+0, 1h+30s, 7d+1d ...")
       fieldset(v-if="st.user.id > 0")
-        label(for="selectPlayers") {{ st.tr["Play with? (optional)"] }}
+        label(for="selectPlayers") {{ st.tr["Play with?"] }}
         input#selectPlayers(type="text" v-model="newchallenge.to")
-      fieldset(v-if="st.user.id > 0")
-        label(for="inputFen") {{ st.tr["FEN (optional)"] }}
+      fieldset(v-if="st.user.id > 0 && newchallenge.to.length > 0")
+        label(for="inputFen") FEN
         input#inputFen(type="text" v-model="newchallenge.fen")
       button(@click="newChallenge") {{ st.tr["Send challenge"] }}
   .row
     .col-sm-12
-      button#newGame(onClick="doClick('modalNewgame')") New game
+      button#newGame(onClick="doClick('modalNewgame')") {{ st.tr["New game"] }}
   .row
     .col-sm-12.col-md-10.col-md-offset-1.col-lg-8.col-lg-offset-2
       div
         .button-group
           button(@click="(e) => setDisplay('c','live',e)" class="active")
-            | Live Challenges
+            | {{ st.tr["Live challenges"] }}
           button(@click="(e) => setDisplay('c','corr',e)")
-            | Correspondance challenges
+            | {{ st.tr["Correspondance challenges"] }}
         ChallengeList(v-show="cdisplay=='live'"
           :challenges="filterChallenges('live')" @click-challenge="clickChallenge")
         ChallengeList(v-show="cdisplay=='corr'"
           :challenges="filterChallenges('corr')" @click-challenge="clickChallenge")
       #people
-        h3.text-center Who's there?
+        h3.text-center {{ st.tr["Who's there?"] }}
         #players
-          p(v-for="p in Object.values(people)" v-if="!!p.name")
-            span {{ p.name }}
+          p(v-for="sid in Object.keys(people)" v-if="!!people[sid].name")
+            span {{ people[sid].name }}
             button.player-action(
-              v-if="p.name != st.user.name"
-              @click="challOrWatch(p,$event)"
+              v-if="people[sid].name != st.user.name"
+              @click="challOrWatch(sid, $event)"
             )
-              | {{ whatPlayerDoes(p) }}
+              | {{ st.tr[!!people[sid].gamer ? 'Playing' : 'Available'] }}
           p.anonymous @nonymous ({{ anonymousCount }})
         #chat
-          Chat(:players="[]")
+          Chat(:newChat="newChat" @mychat="processChat")
         .clearer
       div
         .button-group
           button(@click="(e) => setDisplay('g','live',e)" class="active")
-            | Live games
+            | {{ st.tr["Live games"] }}
           button(@click="(e) => setDisplay('g','corr',e)")
-            | Correspondance games
+            | {{ st.tr["Correspondance games"] }}
         GameList(v-show="gdisplay=='live'" :games="filterGames('live')"
           @show-game="showGame")
         GameList(v-show="gdisplay=='corr'" :games="filterGames('corr')"
@@ -77,6 +83,8 @@ import Chat from "@/components/Chat.vue";
 import GameList from "@/components/GameList.vue";
 import ChallengeList from "@/components/ChallengeList.vue";
 import { GameStorage } from "@/utils/gameStorage";
+import { processModalClick } from "@/utils/modalClick";
+
 export default {
   name: "my-hall",
   components: {
@@ -96,10 +104,11 @@ export default {
       infoMessage: "",
       newchallenge: {
         fen: "",
-        vid: 0,
+        vid: localStorage.getItem("vid") || "",
         to: "", //name of challenged player (if any)
-        timeControl: "", //"2m+2s" ...etc
+        timeControl: localStorage.getItem("timeControl") || "",
       },
+      newChat: "",
     };
   },
   watch: {
@@ -131,8 +140,13 @@ export default {
     const chall = JSON.parse(localStorage.getItem("challenge") || "false");
     if (!!chall)
     {
-      if ((Date.now() - chall.added)/1000 <= 30*60)
+      // NOTE: a challenge survives 3 minutes, for potential connection issues
+      if ((Date.now() - chall.added)/1000 <= 3*60)
+      {
+        chall.added = Date.now(); //update added time, for next disconnect...
         this.challenges.push(chall);
+        localStorage.setItem("challenge", JSON.stringify(chall));
+      }
       else
         localStorage.removeItem("challenge");
     }
@@ -183,6 +197,7 @@ export default {
       // after we're sure WebSocket is initialized
       this.st.conn.send(JSON.stringify({code:"connect"}));
       this.st.conn.send(JSON.stringify({code:"pollclients"}));
+      this.st.conn.send(JSON.stringify({code:"pollgamers"}));
     };
     if (!!this.st.conn && this.st.conn.readyState == 1) //1 == OPEN state
       funcPollClients();
@@ -196,6 +211,15 @@ export default {
     };
     this.st.conn.onclose = socketCloseListener;
   },
+  mounted: function() {
+    [document.getElementById("infoDiv"),document.getElementById("newgameDiv")]
+      .forEach(elt => elt.addEventListener("click", processModalClick));
+    document.querySelectorAll("#predefinedTimeControls > button").forEach(
+      (b) => { b.addEventListener("click",
+        () => { this.newchallenge.timeControl = b.innerHTML; }
+      )}
+    );
+  },
   methods: {
     // Helpers:
     filterChallenges: function(type) {
@@ -229,13 +253,9 @@ export default {
       // this.st.variants might be uninitialized (variant == null)
       return (!!variant ? variant.name : "");
     },
-    whatPlayerDoes: function(p) {
-      if (this.games.some(g => g.type == "live"
-        && g.players.some(pl => pl.sid == p.sid)))
-      {
-        return "Playing";
-      }
-      return "Challenge"; //player is available
+    processChat: function(chat) {
+      // When received on server, this will trigger a "notifyRoom"
+      this.st.conn.send(JSON.stringify({code:"newchat", chat: chat}));
     },
     sendSomethingTo: function(to, code, obj, warnDisconnected) {
       const doSend = (code, obj, sid) => {
@@ -245,21 +265,7 @@ export default {
           {target: sid}
         )));
       };
-      if (!!to)
-      {
-        // Challenge with targeted players
-        const targetSid =
-          Object.keys(this.people).find(sid => this.people[sid].name == to);
-        if (!targetSid)
-        {
-          if (!!warnDisconnected)
-            alert("Warning: " + to + " is not connected");
-          return false;
-        }
-        else
-          doSend(code, obj, targetSid);
-      }
-      else
+      if (!to || (!to.sid && !to.name))
       {
         // Open challenge: send to all connected players (me excepted)
         Object.keys(this.people).forEach(sid => {
@@ -267,6 +273,27 @@ export default {
             doSend(code, obj, sid);
         });
       }
+      else
+      {
+        let targetSid = "";
+        if (!!to.sid)
+          targetSid = to.sid;
+        else
+        {
+          if (to.name == this.st.user.name)
+            return alert(this.st.tr["Cannot challenge self"]);
+          // Challenge with targeted players
+          targetSid =
+            Object.keys(this.people).find(sid => this.people[sid].name == to.name);
+          if (!targetSid)
+          {
+            if (!!warnDisconnected)
+              alert(this.st.tr["Warning: target is not connected"]);
+            return false;
+          }
+        }
+        doSend(code, obj, targetSid);
+      }
       return true;
     },
     // Messaging center:
@@ -275,21 +302,27 @@ export default {
       switch (data.code)
       {
         case "duplicate":
-          alert("Warning: duplicate 'offline' connection");
+          alert(this.st.tr["Warning: multi-tabs not supported"]);
           break;
         // 0.2] Receive clients list (just socket IDs)
         case "pollclients":
-        {
           data.sockIds.forEach(sid => {
             this.$set(this.people, sid, {id:0, name:""});
-            // Ask identity, challenges and game(s)
+            // Ask identity and challenges
             this.st.conn.send(JSON.stringify({code:"askidentity", target:sid}));
             this.st.conn.send(JSON.stringify({code:"askchallenge", target:sid}));
           });
+          break;
+        case "pollgamers":
+          // NOTE: we could make a difference between people in hall
+          // and gamers, but is it necessary?
+          data.sockIds.forEach(sid => {
+            this.$set(this.people, sid, {id:0, name:"", gamer:true});
+            this.st.conn.send(JSON.stringify({code:"askidentity", target:sid}));
+          });
           // Also ask current games to all playing peers (TODO: some design issue)
           this.st.conn.send(JSON.stringify({code:"askgames"}));
           break;
-        }
         case "askidentity":
         {
           // Request for identification: reply if I'm not anonymous
@@ -309,7 +342,11 @@ export default {
         case "identity":
         {
           this.$set(this.people, data.user.sid,
-            {id: data.user.id, name: data.user.name});
+            {
+              id: data.user.id,
+              name: data.user.name,
+              gamer: this.people[data.user.sid].gamer,
+            });
           break;
         }
         case "askchallenge":
@@ -358,7 +395,11 @@ export default {
         {
           // Receive game from some player (+sid)
           // NOTE: it may be correspondance (if newgame while we are connected)
-          if (this.games.every(g => g.id != data.game.id)) //ignore duplicates
+          // If duplicate found: select rid (remote ID) at random
+          let game = this.games.find(g => g.id == data.game.id);
+          if (!!game && Math.random() < 0.5)
+            game.rid = data.from;
+          else
           {
             let newGame = data.game;
             newGame.type = this.classifyObject(data.game);
@@ -387,10 +428,14 @@ export default {
           }
           break;
         }
+        case "newchat":
+          this.newChat = data.chat;
+          break;
         case "refusechallenge":
         {
           ArrayFun.remove(this.challenges, c => c.id == data.cid);
-          alert(this.people[data.from].name + " declined your challenge");
+          localStorage.removeItem("challenge");
+          alert(this.st.tr["Challenge declined"]);
           break;
         }
         case "deletechallenge":
@@ -401,47 +446,55 @@ export default {
           break;
         }
         case "connect":
-        {
-          this.$set(this.people, data.from, {name:"", id:0});
+        case "gconnect":
+          this.$set(this.people, data.from, {name:"", id:0, gamer:data.code[0]=='g'});
           this.st.conn.send(JSON.stringify({code:"askidentity", target:data.from}));
-          this.st.conn.send(JSON.stringify({code:"askchallenge", target:data.from}));
-          this.st.conn.send(JSON.stringify({code:"askgame", target:data.from}));
+          if (data.code == "connect")
+            this.st.conn.send(JSON.stringify({code:"askchallenge", target:data.from}));
+          else
+            this.st.conn.send(JSON.stringify({code:"askgame", target:data.from}));
           break;
-        }
         case "disconnect":
-        {
+        case "pdisconnect":
           this.$delete(this.people, data.from);
-          // Also remove all challenges sent by this player:
-          ArrayFun.remove(this.challenges, c => c.from.sid == data.from);
-          // And all live games where he plays and no other opponent is online
-          ArrayFun.remove(this.games, g =>
-            g.type == "live" && (g.players.every(p => p.sid == data.from
-              || !this.people[p.sid])), "all");
+          if (data.code == "disconnect")
+          {
+            // Also remove all challenges sent by this player:
+            ArrayFun.remove(this.challenges, c => c.from.sid == data.from);
+          }
+          else
+          {
+            // And all live games where he plays and no other opponent is online
+            ArrayFun.remove(this.games, g =>
+              g.type == "live" && (g.players.every(p => p.sid == data.from
+                || !this.people[p.sid])), "all");
+          }
           break;
-        }
       }
     },
     // Challenge lifecycle:
-    tryChallenge: function(player) {
-      if (player.id == 0)
+    tryChallenge: function(sid) {
+      if (this.people[sid].id == 0)
         return; //anonymous players cannot be challenged
-      this.newchallenge.to = player.name;
+      // TODO: SID is available, so we could use it instead of searching from name
+      this.newchallenge.to = this.people[sid].name;
       doClick("modalNewgame");
     },
-    challOrWatch: function(p, e) {
+    challOrWatch: function(sid, e) {
       switch (e.target.innerHTML)
       {
         case "Challenge":
-          this.tryChallenge(p);
+          this.tryChallenge(sid);
           break;
         case "Playing":
-          // NOTE: this search for game was already done for rendering
           this.showGame(this.games.find(
-            g => g.type=="live" && g.players.some(pl => pl.sid == p.sid)));
+            g => g.type=="live" && g.players.some(pl => pl.sid == sid)));
           break;
       };
     },
     newChallenge: async function() {
+      if (this.newchallenge.vid == "")
+        return alert(this.st.tr["Please select a variant"]);
       const vname = this.getVname(this.newchallenge.vid);
       const vModule = await import("@/variants/" + vname + ".js");
       window.V = vModule.VariantRules;
@@ -452,13 +505,13 @@ export default {
         return alert(error);
       const ctype = this.classifyObject(this.newchallenge);
       if (ctype == "corr" && this.st.user.id <= 0)
-        return alert("Please log in to play correspondance games");
+        return alert(this.st.tr["Please log in to play correspondance games"]);
       // NOTE: "from" information is not required here
       let chall = Object.assign({}, this.newchallenge);
       const finishAddChallenge = (cid,warnDisconnected) => {
         chall.id = cid || "c" + getRandString();
         // Send challenge to peers (if connected)
-        const isSent = this.sendSomethingTo(chall.to, "challenge",
+        const isSent = this.sendSomethingTo({name:chall.to}, "challenge",
           {chall:chall}, !!warnDisconnected);
         if (!isSent)
           return;
@@ -468,7 +521,7 @@ export default {
         if (cIdx >= 0)
         {
           // Delete current challenge (will be replaced now)
-          this.sendSomethingTo(this.challenges[cIdx].to,
+          this.sendSomethingTo({name:this.challenges[cIdx].to},
             "deletechallenge", {cid:this.challenges[cIdx].id});
           if (ctype == "corr")
           {
@@ -493,6 +546,9 @@ export default {
         this.challenges.push(chall);
         if (ctype == "live")
           localStorage.setItem("challenge", JSON.stringify(chall));
+        // Also remember timeControl  + vid for quicker further challenges:
+        localStorage.setItem("timeControl", chall.timeControl);
+        localStorage.setItem("vid", chall.vid);
         document.getElementById("modalNewgame").checked = false;
       };
       if (ctype == "live")
@@ -517,7 +573,7 @@ export default {
       if (!myChallenge)
       {
         if (c.type == "corr" && this.st.user.id <= 0)
-          return alert("Please log in to accept corr challenges");
+          return alert(this.st.tr["Please log in to accept corr challenges"]);
         c.accepted = true;
         if (!!c.to) //c.to == this.st.user.name (connected)
         {
@@ -539,7 +595,7 @@ export default {
             code: "refusechallenge",
             cid: c.id, target: c.from.sid}));
         }
-        this.sendSomethingTo((!!c.to ? c.from : null), "deletechallenge", {cid:c.id});
+        this.sendSomethingTo(!!c.to ? {sid:c.from.sid} : null, "deletechallenge", {cid:c.id});
       }
       else //my challenge
       {
@@ -553,7 +609,7 @@ export default {
         }
         else //live
           localStorage.removeItem("challenge");
-        this.sendSomethingTo(c.to, "deletechallenge", {cid:c.id});
+        this.sendSomethingTo({name:c.to}, "deletechallenge", {cid:c.id});
       }
       // In all cases, the challenge is consumed:
       ArrayFun.remove(this.challenges, ch => ch.id == c.id);
@@ -587,6 +643,7 @@ export default {
       };
       if (c.type == "live")
       {
+        // NOTE: in this case we are sure opponent is online
         tryNotifyOpponent();
         this.startNewGame(gameInfo);
       }
@@ -604,14 +661,13 @@ export default {
         );
       }
       // Send game info to everyone except opponent (and me)
-      const playersNames = gameInfo.players.map(p => {name: p.name});
       Object.keys(this.people).forEach(sid => {
-        if (![this.st.user.sid,target].includes(sid))
+        if (![this.st.user.sid,oppsid].includes(sid))
         {
           this.st.conn.send(JSON.stringify({code:"game",
             game: { //minimal game info:
               id: gameInfo.id,
-              players: playersNames,
+              players: gameInfo.players,
               vid: gameInfo.vid,
               timeControl: gameInfo.timeControl,
             },