X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=client%2Fsrc%2Fviews%2FGame.vue;h=5199154ac537f5d0f5774c560892bd9eabb65793;hb=7e355d68b5962aad106e28a9d669a47f3cbec43a;hp=bd9125f26939a463c1dfc9c8e29220ee5aba75fd;hpb=d18bfa126e918ecc13f2a70612b1cfda25e1e25a;p=vchess.git

diff --git a/client/src/views/Game.vue b/client/src/views/Game.vue
index bd9125f2..5199154a 100644
--- a/client/src/views/Game.vue
+++ b/client/src/views/Game.vue
@@ -1,56 +1,33 @@
 <template lang="pug">
 .row
   .col-sm-12.col-md-10.col-md-offset-1.col-lg-8.col-lg-offset-2
-    input#modalAbort.modal(type="checkbox")
-    div(role="dialog" aria-labelledby="abortBoxTitle")
-      .card.smallpad.small-modal.text-center
-        label.modal-close(for="modalAbort")
-        h3#abortBoxTitle.section {{ st.tr["Terminate game?"] }}
-        button(@click="abortGame") {{ st.tr["Sorry I have to go"] }}
-        button(@click="abortGame") {{ st.tr["Game seems over"] }}
-        button(@click="abortGame") {{ st.tr["Game is too boring"] }}
     BaseGame(:game="game" :vr="vr" ref="basegame"
       @newmove="processMove" @gameover="gameOver")
-    // TODO: also show players names
-    div Time: {{ virtualClocks[0] }} - {{ virtualClocks[1] }}
+    div Names: {{ game.players[0].name }} - {{ game.players[1].name }}
+    div(v-if="game.score=='*'") Time: {{ virtualClocks[0] }} - {{ virtualClocks[1] }}
     .button-group(v-if="game.mode!='analyze' && game.score=='*'")
       button(@click="offerDraw") Draw
-      button(@click="() => abortGame()") Abort
+      button(@click="abortGame") Abort
       button(@click="resign") Resign
-    div(v-if="game.mode=='corr'")
-      textarea(v-show="score=='*' && vr.turn==game.mycolor" v-model="corrMsg")
-      div(v-show="cursor>=0") {{ moves[cursor].message }}
+    div(v-if="game.type=='corr'") {{ game.corrMsg }}
+    textarea(v-if="game.score=='*'" v-model="corrMsg")
+    Chat(:players="game.players")
 </template>
 
-<!--
-// TODO: movelist dans basegame et chat ici
-// ==> après, implémenter/vérifier les passages de challenges + parties en cours
-// observer,
-// + problèmes, habiller et publier. (+ corr...)
-    // TODO: how to know who is observing ? Send message to everyone with game ID ?
-    // and then just listen to (dis)connect events
-    // server always send "connect on " + URL ; then add to observers if game...
-// router when access a game page tell to server I joined + game ID (no need rid)
-// and ask server for current joined (= observers)
-// when send to chat (or a move), reach only this group (send gid along)
-// -> doivent être enregistrés comme observers au niveau du serveur...
-    // non: poll users + events startObserving / stopObserving
-    // (à faire au niveau du routeur ?)
--->
-
 <script>
 import BaseGame from "@/components/BaseGame.vue";
-//import Chat from "@/components/Chat.vue";
-//import MoveList from "@/components/MoveList.vue";
+import Chat from "@/components/Chat.vue";
 import { store } from "@/store";
 import { GameStorage } from "@/utils/gameStorage";
 import { ppt } from "@/utils/datetime";
 import { extractTime } from "@/utils/timeControl";
+import { ArrayFun } from "@/utils/array";
 
 export default {
   name: 'my-game',
   components: {
     BaseGame,
+    Chat,
   },
   // gameRef: to find the game in (potentially remote) storage
   data: function() {
@@ -60,28 +37,25 @@ export default {
         id: "",
         rid: ""
       },
-      game: { }, //passed to BaseGame
-      oppConnected: false, //TODO: use for styling
+      game: {players:[{name:""},{name:""}]}, //passed to BaseGame
       corrMsg: "", //to send offline messages in corr games
       virtualClocks: [0, 0], //initialized with true game.clocks
       vr: null, //"variant rules" object initialized from FEN
       drawOffer: "", //TODO: use for button style
-      people: [ ], //potential observers (TODO)
+      people: [], //players + observers
+      lastate: undefined, //used if opponent send lastate before game is ready
     };
   },
   watch: {
-    '$route' (to, from) {
-      if (!!to.params["id"])
-      {
-        this.gameRef.id = to.params["id"];
-        this.gameRef.rid = to.query["rid"];
-        this.loadGame();
-      }
+    "$route": function(to, from) {
+      this.gameRef.id = to.params["id"];
+      this.gameRef.rid = to.query["rid"];
+      this.loadGame();
     },
     "game.clocks": function(newState) {
-      if (this.game.moves.length < 2)
+      if (this.game.moves.length < 2 || this.game.score != "*")
       {
-        // 1st move not completed yet: freeze time
+        // 1st move not completed yet, or game over: freeze time
         this.virtualClocks = newState.map(s => ppt(s));
         return;
       }
@@ -95,20 +69,12 @@ export default {
           : 0;
         return ppt(newState[i] - removeTime);
       });
-      const myTurn = (currentTurn == this.game.mycolor);
       let clockUpdate = setInterval(() => {
-        if (countdown <= 0 || this.vr.turn != currentTurn || this.game.score != "*")
+        if (countdown < 0 || this.vr.turn != currentTurn || this.game.score != "*")
         {
           clearInterval(clockUpdate);
-          if (countdown <= 0 && myTurn)
-          {
-            this.$refs["basegame"].endGame(
-              this.game.mycolor=="w" ? "0-1" : "1-0", "Time");
-            this.st.conn.send(JSON.stringify({
-              code: "timeover",
-              target: this.game.oppid,
-            }));
-          }
+          if (countdown < 0)
+            this.setScore(this.vr.turn=="w" ? "0-1" : "1-0", "Time");
         }
         else
         {
@@ -117,274 +83,342 @@ export default {
         }
       }, 1000);
     },
-    // In case variants array was't loaded when game was retrieved
-    "st.variants": function(variantArray) {
-      if (!!this.game.vname && this.game.vname == "")
-        this.game.vname = variantArray.filter(v => v.id == this.game.vid)[0].name;
-    },
   },
+  // TODO: redundant code with Hall.vue (related to people array)
   created: function() {
-    if (!!this.$route.params["id"])
-    {
-      this.gameRef.id = this.$route.params["id"];
-      this.gameRef.rid = this.$route.query["rid"];
-      this.loadGame();
-    }
-    // TODO: onopen, ask lastState informations + update observers and players status
+    // Always add myself to players' list
+    const my = this.st.user;
+    this.people.push({sid:my.sid, id:my.id, name:my.name});
+    this.gameRef.id = this.$route.params["id"];
+    this.gameRef.rid = this.$route.query["rid"]; //may be undefined
+    // Define socket .onmessage() and .onclose() events:
+    this.st.conn.onmessage = this.socketMessageListener;
     const socketCloseListener = () => {
       store.socketCloseListener(); //reinitialize connexion (in store.js)
       this.st.conn.addEventListener('message', this.socketMessageListener);
       this.st.conn.addEventListener('close', socketCloseListener);
     };
-    this.st.conn.onmessage = this.socketMessageListener;
     this.st.conn.onclose = socketCloseListener;
+    // Socket init required before loading remote game:
+    const socketInit = (callback) => {
+      if (!!this.st.conn && this.st.conn.readyState == 1) //1 == OPEN state
+        callback();
+      else //socket not ready yet (initial loading)
+        this.st.conn.onopen = callback;
+    };
+    if (!this.gameRef.rid) //game stored locally or on server
+      this.loadGame(null, () => socketInit(this.roomInit));
+    else //game stored remotely: need socket to retrieve it
+    {
+      // NOTE: the callback "roomInit" will be lost, so we don't provide it.
+      // --> It will be given when receiving "fullgame" socket event.
+      // A more general approach would be to store it somewhere.
+      socketInit(this.loadGame);
+    }
   },
   methods: {
+    // O.1] Ask server for room composition:
+    roomInit: function() {
+      this.st.conn.send(JSON.stringify({code:"pollclients"}));
+    },
     socketMessageListener: function(msg) {
       const data = JSON.parse(msg.data);
       switch (data.code)
       {
-        case "newmove":
-          // NOTE: next call will trigger processMove()
-          this.$refs["basegame"].play(data.move,
-            "receive", this.game.vname!="Dark" ? "animate" : null);
+        case "duplicate":
+          alert("Warning: duplicate 'offline' connection");
           break;
-        case "pong": //received if we sent a ping (game still alive on our side)
+        // 0.2] Receive clients list (just socket IDs)
+        case "pollclients":
         {
-          this.oppConnected = true;
-          if (this.game.type == "live") //corr games are always complete
-          {
-            // Send our "last state" informations to opponent(s)
-            const L = this.game.moves.length;
-            this.st.conn.send(JSON.stringify({
-              code: "lastate",
-              target: this.game.oppid,
-              gameId: this.gameRef.id,
-              lastMove: (L>0 ? this.game.moves[L-1] : undefined),
-              score: this.game.score,
-              movesCount: L,
-              drawOffer: this.drawOffer,
-              clocks: this.game.clocks,
-            }));
-          }
+          data.sockIds.forEach(sid => {
+            this.people.push({sid:sid, id:0, name:""});
+            // Ask only identity
+            this.st.conn.send(JSON.stringify({code:"askidentity", target:sid}));
+          });
           break;
         }
-        case "lastate": //got opponent infos about last move
+        case "askidentity":
         {
-          const L = this.game.moves.length;
-          if (this.gameRef.id != data.gameId)
-            break; //games IDs don't match: nothing we can do...
-          // OK, opponent still in game (which might be over)
-          if (data.movesCount > L)
+          // Request for identification: reply if I'm not anonymous
+          if (this.st.user.id > 0)
           {
-            // Just got last move from him
-            this.$refs["basegame"].play(data.lastMove, "receive");
-            if (data.score != "*" && this.game.score == "*")
-            {
-              // Opponent resigned or aborted game, or accepted draw offer
-              // (this is not a stalemate or checkmate)
-              this.$refs["basegame"].endGame(data.score, "Opponent action");
-            }
-            this.game.clocks = data.clocks;
-            this.drawOffer = data.drawOffer;
+            this.st.conn.send(JSON.stringify(
+              // people[0] instead of st.user to avoid sending email
+              {code:"identity", user:this.people[0], target:data.from}));
           }
-          else if (data.movesCount < L)
+          break;
+        }
+        case "identity":
+        {
+          let player = this.people.find(p => p.sid == data.user.sid);
+          // NOTE: sometimes player.id fails because player is undefined...
+          // Probably because the event was meant for Hall?
+          if (!player)
+            return;
+          player.id = data.user.id;
+          player.name = data.user.name;
+          // Sending last state only for live games: corr games are complete
+          if (this.game.type == "live" && this.game.oppsid == player.sid)
           {
-            // We must tell last move to opponent
+            // Send our "last state" informations to opponent
+            const L = this.game.moves.length;
+            let lastMove = (L>0 ? this.game.moves[L-1] : undefined);
+            if (!!lastMove && this.drawOffer == "sent")
+              lastMove.draw = true;
             this.st.conn.send(JSON.stringify({
               code: "lastate",
-              target: this.game.oppid,
-              gameId: this.gameRef.id,
-              lastMove: (L>0 ? this.game.moves[L-1] : undefined),
-              score: this.game.score,
-              movesCount: L,
-              drawOffer: this.drawOffer,
-              clocks: this.game.clocks,
+              target: player.sid,
+              state:
+              {
+                lastMove: lastMove,
+                score: this.game.score,
+                movesCount: L,
+                clocks: this.game.clocks,
+              }
             }));
           }
           break;
         }
-        case "resign":
-          this.$refs["basegame"].endGame(
-            this.game.mycolor=="w" ? "1-0" : "0-1", "Resign");
+        case "askgame":
+          // Send current (live) game
+          const myGame =
+          {
+            // Minimal game informations:
+            id: this.game.id,
+            players: this.game.players.map(p => { return {name:p.name}; }),
+            vid: this.game.vid,
+            timeControl: this.game.timeControl,
+          };
+          this.st.conn.send(JSON.stringify({code:"game",
+            game:myGame, target:data.from}));
+          break;
+        case "newmove":
+          this.corrMsg = data.move.message; //may be empty
+          this.game.moveToPlay = data.move;
           break;
-        case "timeover":
-          this.$refs["basegame"].endGame(
-            this.game.mycolor=="w" ? "1-0" : "0-1", "Time");
+        case "lastate": //got opponent infos about last move
+        {
+          this.lastate = data;
+          if (!!this.game.type) //game is loaded
+            this.processLastate();
+          //else: will be processed when game is ready
+          break;
+        }
+        case "resign":
+          this.setScore(data.side=="b" ? "1-0" : "0-1", "Resign");
           break;
         case "abort":
-          this.$refs["basegame"].endGame("?", "Abort: " + data.msg);
+          this.setScore("?", "Abort");
           break;
         case "draw":
-          this.$refs["basegame"].endGame("1/2", "Mutual agreement");
+          this.setScore("1/2", "Mutual agreement");
           break;
         case "drawoffer":
-          this.drawOffer = "received";
+          this.drawOffer = "received"; //TODO: observers don't know who offered draw
           break;
         case "askfullgame":
-          // TODO: just give game; observers are listed here anyway:
-          // gameconnect?
+          this.st.conn.send(JSON.stringify({code:"fullgame", game:this.game, target:data.from}));
           break;
-        // TODO: drawaccepted (click draw button before sending move ==> draw offer in move)
-          // ==> on "newmove", check "drawOffer" field
-        // TODO: also use (dis)connect info to count online players?
-        case "gameconnect":
-        case "gamedisconnect":
-          const online = (data.code == "gameconnect");
-          // If this is an opponent ?
-          if (this.game.oppid == data.id)
-            this.oppConnected = true;
-          else
-          {
-            // Or an observer ?
-            if (!online)
-              delete this.people[data.id];
-            else
-              this.people[data.id] = data.name;
-          }
+        case "fullgame":
+          // Callback "roomInit" to poll clients only after game is loaded
+          this.loadGame(data.game, this.roomInit);
+          break;
+        case "connect":
+        {
+          this.people.push({name:"", id:0, sid:data.from});
+          this.st.conn.send(JSON.stringify({code:"askidentity", target:data.from}));
+          break;
+        }
+        case "disconnect":
+          ArrayFun.remove(this.people, p => p.sid == data.from);
           break;
       }
     },
+    // lastate was received, but maybe game wasn't ready yet:
+    processLastate: function() {
+      const data = this.lastate;
+      this.lastate = undefined; //security...
+      const L = this.game.moves.length;
+      if (data.movesCount > L)
+      {
+        // Just got last move from him
+        this.game.moveToPlay = data.lastMove;
+        if (data.score != "*" && this.game.score == "*")
+        {
+          // Opponent resigned or aborted game, or accepted draw offer
+          // (this is not a stalemate or checkmate)
+          this.setScore(data.score, "Opponent action");
+        }
+        this.game.clocks = data.clocks; //TODO: check this?
+        if (!!data.lastMove.draw)
+          this.drawOffer = "received";
+      }
+    },
+    setScore: function(score, message) {
+      this.game.scoreMsg = message;
+      this.game.score = score;
+    },
     offerDraw: function() {
-      // TODO: also for corr games
       if (this.drawOffer == "received")
       {
         if (!confirm("Accept draw?"))
           return;
-        this.st.conn.send(JSON.stringify({code:"draw", target:this.game.oppid}));
-        this.$refs["basegame"].endGame("1/2", "Mutual agreement");
+        this.people.forEach(p => {
+          if (p.sid != this.st.user.sid)
+            this.st.conn.send(JSON.stringify({code:"draw", target:p.sid}));
+        });
+        this.setScore("1/2", "Mutual agreement");
       }
       else if (this.drawOffer == "sent")
+      {
         this.drawOffer = "";
+        if (this.game.type == "corr")
+          GameStorage.update(this.gameRef.id, {drawOffer: false});
+      }
       else
       {
         if (!confirm("Offer draw?"))
           return;
-        this.st.conn.send(JSON.stringify({code:"drawoffer", target:this.game.oppid}));
+        this.drawOffer = "sent";
+        this.people.forEach(p => {
+          if (p.sid != this.st.user.sid)
+            this.st.conn.send(JSON.stringify({code:"drawoffer", target:p.sid}));
+        });
+        if (this.game.type == "corr")
+          GameStorage.update(this.gameRef.id, {drawOffer: true});
       }
     },
-    // + conn handling: "draw" message ==> agree for draw (if we have "drawOffered" at true)
-    receiveDrawOffer: function() {
-      //if (...)
-      // TODO: ignore if preventDrawOffer is set; otherwise show modal box with option "prevent future offers"
-      // if accept: send message "draw"
-    },
-    abortGame: function(event) {
-      let modalBox = document.getElementById("modalAbort");
-      if (!event)
-      {
-        // First call show options:
-        modalBox.checked = true;
-      }
-      else
-      {
-        modalBox.checked = false; //decision made: box disappear
-        const message = event.target.innerText;
-        // Next line will trigger a "gameover" event, bubbling up till here
-        this.$refs["basegame"].endGame("?", "Abort: " + message);
-        this.st.conn.send(JSON.stringify({
-          code: "abort",
-          msg: message,
-          target: this.game.oppid,
-        }));
-      }
+    abortGame: function() {
+      if (!confirm(this.st.tr["Terminate game?"]))
+        return;
+      this.setScore("?", "Abort");
+      this.people.forEach(p => {
+        if (p.sid != this.st.user.sid)
+        {
+          this.st.conn.send(JSON.stringify({
+            code: "abort",
+            target: p.sid,
+          }));
+        }
+      });
     },
     resign: function(e) {
       if (!confirm("Resign the game?"))
         return;
-      this.st.conn.send(JSON.stringify({
-        code: "resign",
-        target: this.game.oppid,
-      }));
-      // Next line will trigger a "gameover" event, bubbling up till here
-      this.$refs["basegame"].endGame(
-        this.game.mycolor=="w" ? "0-1" : "1-0", "Resign");
+      this.people.forEach(p => {
+        if (p.sid != this.st.user.sid)
+        {
+          this.st.conn.send(JSON.stringify({code:"resign",
+            side:this.game.mycolor, target:p.sid}));
+        }
+      });
+      this.setScore(this.game.mycolor=="w" ? "0-1" : "1-0", "Resign");
     },
     // 3 cases for loading a game:
     //  - from indexedDB (running or completed live game I play)
     //  - from server (one correspondance game I play[ed] or not)
     //  - from remote peer (one live game I don't play, finished or not)
-    loadGame: function(game) {
+    loadGame: function(game, callback) {
       const afterRetrieval = async (game) => {
-        // NOTE: variants array might not be available yet, thus the two next lines
-        const variantCell = this.st.variants.filter(v => v.id == game.vid);
-        const vname = (variantCell.length > 0 ? variantCell[0].name : "");
-        if (!game.fen)
-          game.fen = game.fenStart; //game wasn't started
+        const vModule = await import("@/variants/" + game.vname + ".js");
+        window.V = vModule.VariantRules;
+        this.vr = new V(game.fen);
         const gtype = (game.timeControl.indexOf('d') >= 0 ? "corr" : "live");
+        const tc = extractTime(game.timeControl);
         if (gtype == "corr")
         {
+          if (game.players[0].color == "b")
+          {
+            // Adopt the same convention for live and corr games: [0] = white
+            [ game.players[0], game.players[1] ] =
+              [ game.players[1], game.players[0] ];
+          }
           // corr game: needs to compute the clocks + initime
-          //if (game.players[i].rtime < 0) initime = Date.now(), else compute,
-          //also using move.played fields
-          game.clocks = [-1, -1];
-          game.initime = [0, 0];
-          // TODO: compute clocks + initime
+          // NOTE: clocks in seconds, initime in milliseconds
+          game.clocks = [tc.mainTime, tc.mainTime];
+          game.moves.sort((m1,m2) => m1.idx - m2.idx); //in case of
+          if (game.score == "*") //otherwise no need to bother with time
+          {
+            game.initime = [0, 0];
+            const L = game.moves.length;
+            if (L >= 3)
+            {
+              let addTime = [0, 0];
+              for (let i=2; i<L; i++)
+              {
+                addTime[i%2] += tc.increment -
+                  (game.moves[i].played - game.moves[i-1].played) / 1000;
+              }
+              for (let i=0; i<=1; i++)
+                game.clocks[i] += addTime[i];
+            }
+            if (L >= 1)
+              game.initime[L%2] = game.moves[L-1].played;
+            if (game.drawOffer)
+              this.drawOffer = "received";
+          }
+          // Now that we used idx and played, re-format moves as for live games
+          game.moves = game.moves.map( (m) => {
+            const s = m.squares;
+            return {
+              appear: s.appear,
+              vanish: s.vanish,
+              start: s.start,
+              end: s.end,
+              message: m.message,
+            };
+          });
         }
-        const tc = extractTime(game.timeControl);
-        // TODO: this is not really beautiful (uid on corr players...)
-        if (gtype == "corr" && game.players[0].color == "b")
-          [ game.players[0], game.players[1] ] = [ game.players[1], game.players[0] ];
         const myIdx = game.players.findIndex(p => {
           return p.sid == this.st.user.sid || p.uid == this.st.user.id;
         });
-        if (game.clocks[0] < 0) //game unstarted
+        if (gtype == "live" && game.clocks[0] < 0) //game unstarted
         {
           game.clocks = [tc.mainTime, tc.mainTime];
-          game.initime[0] = Date.now();
-          if (myIdx >= 0) //I play in this game
+          if (game.score == "*")
           {
-            GameStorage.update(game.id,
+            game.initime[0] = Date.now();
+            if (myIdx >= 0)
             {
-              clocks: game.clocks,
-              initime: game.initime,
-            });
+              // I play in this live game; corr games don't have clocks+initime
+              GameStorage.update(game.id,
+              {
+                clocks: game.clocks,
+                initime: game.initime,
+              });
+            }
           }
         }
-        const vModule = await import("@/variants/" + vname + ".js");
-        window.V = vModule.VariantRules;
-        this.vr = new V(game.fen);
-        
-
-
-//TODO: people, on connect, search for opponent.......
-console.log(myIdx + " " + game.players[1-myIdx].sid); //otherwise this is undefined:
-
-
-
         this.game = Object.assign({},
           game,
-          // NOTE: assign mycolor here, since BaseGame could also bs VS computer
+          // NOTE: assign mycolor here, since BaseGame could also be VS computer
           {
             type: gtype,
             increment: tc.increment,
-            vname: vname,
             mycolor: [undefined,"w","b"][myIdx+1],
-            // opponent sid not strictly required, but easier
-            oppid: (myIdx < 0 ? undefined : game.players[1-myIdx].sid),
+            // opponent sid not strictly required (or available), but easier
+            // at least oppsid or oppid is available anyway:
+            oppsid: (myIdx < 0 ? undefined : game.players[1-myIdx].sid),
+            oppid: (myIdx < 0 ? undefined : game.players[1-myIdx].uid),
           }
         );
-        if (!!this.game.oppid)
-        {
-          // Send ping to server (answer pong if players[s] are connected)
-          this.st.conn.send(JSON.stringify({code:"ping", target:this.game.oppid}));
-        }
+        if (!!this.lastate) //lastate arrived before game was loaded:
+          this.processLastate();
+        callback();
       };
       if (!!game)
-        return afterRetrival(game);
+        return afterRetrieval(game);
       if (!!this.gameRef.rid)
       {
-        this.st.conn.send(JSON.stringify({code:"askfullgame", target:this.gameRef.rid}));
-        // TODO: just send a game request message to the remote player,
-        // and when receiving answer just call loadGame(received_game)
-        // + remote peer should have registered us as an observer
-        // (send moves updates + resign/abort/draw actions)
+        // Remote live game: forgetting about callback func... (TODO: design)
+        this.st.conn.send(JSON.stringify(
+          {code:"askfullgame", target:this.gameRef.rid}));
       }
       else
       {
-        GameStorage.get(this.gameRef.id, async (game) => {
-          afterRetrieval(game);
-        });
+        // Local or corr game
+        GameStorage.get(this.gameRef.id, afterRetrieval);
       }
     },
     // Post-process a move (which was just played)
@@ -401,7 +435,7 @@ console.log(myIdx + " " + game.players[1-myIdx].sid); //otherwise this is undefi
           obj[key] = move[key];
           return obj;
         }, {});
-      // Send move ("newmove" event) to opponent(s) (if ours)
+      // Send move ("newmove" event) to people in the room (if our turn)
       let addTime = 0;
       if (move.color == this.game.mycolor)
       {
@@ -411,38 +445,71 @@ console.log(myIdx + " " + game.players[1-myIdx].sid); //otherwise this is undefi
           // elapsed time is measured in milliseconds
           addTime = this.game.increment - elapsed/1000;
         }
-        this.st.conn.send(JSON.stringify({
-          code: "newmove",
-          target: this.game.oppid,
-          move: Object.assign({}, filtered_move, {addTime: addTime}),
-        }));
+        let sendMove = Object.assign({}, filtered_move, {addTime: addTime});
+        if (this.game.type == "corr")
+          sendMove.message = this.corrMsg;
+        this.people.forEach(p => {
+          if (p.sid != this.st.user.sid)
+          {
+            this.st.conn.send(JSON.stringify({
+              code: "newmove",
+              target: p.sid,
+              move: sendMove,
+            }));
+          }
+        });
       }
       else
         addTime = move.addTime; //supposed transmitted
       const nextIdx = ["w","b"].indexOf(this.vr.turn);
-      GameStorage.update(this.gameRef.id,
+      // Since corr games are stored at only one location, update should be
+      // done only by one player for each move:
+      if (this.game.type == "live" || move.color == this.game.mycolor)
       {
-        move: filtered_move,
-        fen: move.fen,
-        clocks: this.game.clocks.map((t,i) => i==colorIdx
-          ? this.game.clocks[i] + addTime
-          : this.game.clocks[i]),
-        initime: this.game.initime.map((t,i) => i==nextIdx
-          ? Date.now()
-          : this.game.initime[i]),
-      });
+        if (this.game.type == "corr")
+        {
+          GameStorage.update(this.gameRef.id,
+          {
+            fen: move.fen,
+            message: this.corrMsg,
+            move:
+            {
+              squares: filtered_move,
+              played: Date.now(), //TODO: on server?
+              idx: this.game.moves.length,
+            },
+          });
+        }
+        else //live
+        {
+          GameStorage.update(this.gameRef.id,
+          {
+            fen: move.fen,
+            move: filtered_move,
+            clocks: this.game.clocks.map((t,i) => i==colorIdx
+              ? this.game.clocks[i] + addTime
+              : this.game.clocks[i]),
+            initime: this.game.initime.map((t,i) => i==nextIdx
+              ? Date.now()
+              : this.game.initime[i]),
+          });
+        }
+      }
       // Also update current game object:
       this.game.moves.push(move);
       this.game.fen = move.fen;
-      //TODO: just this.game.clocks[colorIdx] += addTime;
+      //TODO: (Vue3) just this.game.clocks[colorIdx] += addTime;
       this.$set(this.game.clocks, colorIdx, this.game.clocks[colorIdx] + addTime);
       this.game.initime[nextIdx] = Date.now();
     },
-    // TODO: this update function should also work for corr games
     gameOver: function(score) {
       this.game.mode = "analyze";
       this.game.score = score;
-      GameStorage.update(this.gameRef.id, { score: score });
+      const myIdx = this.game.players.findIndex(p => {
+        return p.sid == this.st.user.sid || p.uid == this.st.user.id;
+      });
+      if (myIdx >= 0) //OK, I play in this game
+        GameStorage.update(this.gameRef.id, { score: score });
     },
   },
 };