X-Git-Url: https://git.auder.net/?a=blobdiff_plain;f=client%2Fsrc%2Futils%2Fajax.js;h=83b045c02bbda02ccd87a2bf24f34848ca4dbea5;hb=6f57a9769ad80459d086abf5232d01ec1ce7a470;hp=c0ebbffcf4b256be24f9a4811f5da138f9cb93c1;hpb=98f485791e915563996de4f37430b285ffc773ae;p=vchess.git diff --git a/client/src/utils/ajax.js b/client/src/utils/ajax.js index c0ebbffc..83b045c0 100644 --- a/client/src/utils/ajax.js +++ b/client/src/utils/ajax.js @@ -1,5 +1,8 @@ import params from "../parameters"; //for server URL +// TODO: replace by fetch API ? +// https://www.sitepoint.com/xmlhttprequest-vs-the-fetch-api-whats-best-for-ajax-in-2019/ + // From JSON (encoded string values!) to "arg1=...&arg2=..." function toQueryString(data) { @@ -14,15 +17,16 @@ function toQueryString(data) export function ajax(url, method, data, success, error) { let xhr = new XMLHttpRequest(); - if (typeof(data) === "function") //no data + if (data === undefined || typeof(data) === "function") //no data { error = success; success = data; data = {}; } + if (!success) + success = () => {}; //by default, do nothing if (!error) error = errmsg => { alert(errmsg); }; - xhr.onreadystatechange = function() { if (this.readyState == 4 && this.status == 200) { @@ -33,10 +37,15 @@ export function ajax(url, method, data, success, error) // Plain text (e.g. for rules retrieval) return success(xhr.responseText); } - if (!res_json.errmsg) + if (!res_json.errmsg && !res_json.errno) success(res_json); else - error(res_json.errmsg); + { + if (!!res_json.errmsg) + error(res_json.errmsg); + else + error(res_json.code + ". errno = " + res_json.errno); + } } };