X-Git-Url: https://git.auder.net/%3C?a=blobdiff_plain;f=client%2Fsrc%2Fbase_rules.js;h=6da3212f51b52b5787bcfd1825d65634fcda52db;hb=d85f259cd57ad8ce2e4137f2291da855a63fd53d;hp=f9574004f5973f2e6cef6911a392b04754c9085d;hpb=6f2f94374f1e73c375edf732d9425e575e81fff7;p=vchess.git

diff --git a/client/src/base_rules.js b/client/src/base_rules.js
index f9574004..6da3212f 100644
--- a/client/src/base_rules.js
+++ b/client/src/base_rules.js
@@ -191,9 +191,9 @@ export const ChessRules = class ChessRules {
     return V.CoordToColumn(coords.y) + (V.size.x - coords.x);
   }
 
-  // Path to pieces
+  // Path to pieces (standard ones in pieces/ folder)
   getPpath(b) {
-    return b; //usual pieces in pieces/ folder
+    return b;
   }
 
   // Path to promotion pieces (usually the same)
@@ -679,6 +679,7 @@ export const ChessRules = class ChessRules {
       enpassantMove.vanish.push({
         x: x,
         y: epSquare.y,
+        // Captured piece is usually a pawn, but next line seems harmless
         p: this.getPiece(x, epSquare.y),
         c: this.getColor(x, epSquare.y)
       });
@@ -1100,7 +1101,9 @@ export const ChessRules = class ChessRules {
     ) {
       const flagIdx = (move.start.y == this.castleFlags[c][0] ? 0 : 1);
       this.castleFlags[c][flagIdx] = V.size.y;
-    } else if (
+    }
+    // NOTE: not "else if" because a rook could take an opposing rook
+    if (
       move.end.x == oppFirstRank && //we took opponent rook?
       this.castleFlags[oppCol].includes(move.end.y)
     ) {
@@ -1281,8 +1284,8 @@ export const ChessRules = class ChessRules {
     }
 
     let candidates = [0];
-    for (let j = 1; j < moves1.length && moves1[j].eval == moves1[0].eval; j++)
-      candidates.push(j);
+    for (let i = 1; i < moves1.length && moves1[i].eval == moves1[0].eval; i++)
+      candidates.push(i);
     return moves1[candidates[randInt(candidates.length)]];
   }